Makes the launcher auto-hide for maximized windows. This turned out to

Makes the launcher auto-hide for maximized windows. This turned out to
be a bit icky for a handful of reasons. In particular it means the
work area changes after going maximized so that you can't assume
maximized windows get the work area bounds. This makes for some
ordering dependencies. I've had to expose the bounds for maximized
windows (and non-maximized windows).

The code feels a bit messy in a number of places right now. In
particular there a handful of places (in testing code) mucking with
work area insets. We don't want that as it generally doesn't do the
right thing anymore.

BUG=116070
118671
TEST=covered by tests, but all see bugs.
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127904

[Ben Goodger (Google), 2012-03-21 05:16:50]

LGTM

like you, i feel a bit icky. we should revisit this in 20.

http://codereview.chromium.org/9764008/diff/2001/ash/launcher/launcher.cc
File ash/launcher/launcher.cc (right):

http://codereview.chromium.org/9764008/diff/2001/ash/launcher/launcher.cc#new...
ash/launcher/launcher.cc:40: public views::AccessiblePaneView{
you lost a space here

http://codereview.chromium.org/9764008/diff/2001/ash/launcher/launcher.cc#new...
ash/launcher/launcher.cc:235: int alpha = animation->CurrentValueBetween(0,
128);
kOnstant