The code looks good but I still want a test that asserts that the instance is an
exotic array object. I would like at least Array.isArray and a case using concat
(maybe even JSON.stringify)
LGTM https://codereview.chromium.org/975463002/diff/70001/test/mjsunit/harmony/classes-subclass-arrays.js File test/mjsunit/harmony/classes-subclass-arrays.js (right): https://codereview.chromium.org/975463002/diff/70001/test/mjsunit/harmony/classes-subclass-arrays.js#newcode20 test/mjsunit/harmony/classes-subclass-arrays.js:20: assertEquals('xyz', s1[0]); Inconsistent use of assertSame and assertEquals?
arv@ could you take a look at this another attempt at fixing arm?
I have validated locally that it builds with a cross-compiler.
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-array.cc File src/runtime/runtime-array.cc (right): https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-array.cc#newcode1167 src/runtime/runtime-array.cc:1167: CHECK(args_length >= 2); Does this need to be ...
Issue 975463002: Implement subclassing Arrays.
(Closed)
Created 6 years ago by Dmitry Lomov (no reviews)
Modified 6 years ago
Reviewers: arv (Not doing code reviews), mvstanton, rossberg
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Comments: 4