Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 9749003: Revert 127660 - WebUI TaskManager: Add method to set minimum window size on HTMLDialog. (Closed)

Created:
8 years, 9 months ago by battre
Modified:
8 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, tfarina, yoshiki+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 127660 - WebUI TaskManager: Add method to set minimum window size on HTMLDialog. Previously, the saved window size is used as the "minimum" size of window on HTMLDialog (cf. http://crbug.com/115403). This CL make the saved size as default size and adds the GetMinimumDialogSize() method in HTMLDialogUI to set minimum size of window separately. This CL also enables the viwes::Widget::SaveWindowPlacement() on TaskManagerDialog by adding HtmlDialogView::GetWindowName() and HtmlDialogUIDelegate::GetDialogName() virtual functions. And this CL disables to save the window placement on TaskManagerDialog on views, since views::Widget has same feature which is enabled by this CL. BUG=115403 TEST=manual on Windows, Linux with gtk and Linux with chromiumos=1 Review URL: http://codereview.chromium.org/9569001 Reverting the CL, with the suspicion that it causes PrintDialogCloudTest.HandlersRegistered and ProtectorServiceTest.ShowAndDiscardManually to time out on Windows. TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -96 lines) Patch
MM chrome/browser/ui/cocoa/html_dialog_window_controller.mm View 2 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/ui/gtk/html_dialog_gtk.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view.cc View 6 chunks +2 lines, -22 lines 0 comments Download
MM chrome/browser/ui/webui/html_dialog_ui.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_ui.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_dialog.cc View 6 chunks +1 line, -19 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
battre
8 years, 9 months ago (2012-03-20 11:45:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698