lib/dom/templates/html/dartium/html_dartium.darttemplate - Issue 9732019: dart:html perf optimization based on runing Dromaeo benchmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/templates/html/dartium/html_dartium.darttemplate

Issue 9732019: dart:html perf optimization based on runing Dromaeo benchmarks (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Respond to code review comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/dom/scripts/systemhtml.py ('k') | lib/dom/templates/html/dartium/impl_Document.darttemplate » ('j') | samples/third_party/dromaeo/tests/dom-query.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/dom/templates/html/dartium/html_dartium.darttemplate

diff --git a/lib/dom/templates/html/dartium/html_dartium.darttemplate b/lib/dom/templates/html/dartium/html_dartium.darttemplate

index f099dd8aef46ed501c5714b3940f344bbd270a90..e1dfa063d2e632ac42b1bee21f3f8b1ef9f5efba 100644

--- a/lib/dom/templates/html/dartium/html_dartium.darttemplate

+++ b/lib/dom/templates/html/dartium/html_dartium.darttemplate

@@ -32,7 +32,7 @@ _DocumentImpl __document;

void _initialize() {

__window = _wrap(dom.window);

- __document = _wrap(dom.document.documentElement);

+ __document = _wrap(dom.document);

}

Window get window() {

@@ -74,13 +74,11 @@ _wrap(raw) {

if (domObject.dartObjectLocalStorage != null)

return domObject.dartObjectLocalStorage;

switch(domObject.typeName) {

- case 'HTMLDocument':

- throw 'A document should never be wrapped directly. TODO(jacobr) XXX';

- case 'HTMLHtmlElement':

- return new _DocumentImpl._wrap(domObject);

case 'HTMLElement':

return new _UnknownElementImpl._wrap(domObject);

$WRAPCASES

+ case 'HTMLDocument':

+ return new _DocumentImpl._wrap(domObject);

default:

throw 'Unrecognized object $domObject. Name=${domObject.typeName}';

}