Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: samples/third_party/dromaeo/tests/dom-query.html

Issue 9732019: dart:html perf optimization based on runing Dromaeo benchmarks (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Respond to code review comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/third_party/dromaeo/tests/dom-query.html
diff --git a/samples/third_party/dromaeo/tests/dom-query.html b/samples/third_party/dromaeo/tests/dom-query.html
index bc1d9098a26a295d826e2cbd644f395aa085f298..fc260f3edc190fa6490d2df290310ffd6ce4830f 100644
--- a/samples/third_party/dromaeo/tests/dom-query.html
+++ b/samples/third_party/dromaeo/tests/dom-query.html
@@ -44,35 +44,45 @@ var html = document.body.innerHTML;
test( "getElementsByTagName(div)", function(){
for ( var i = 0; i < num; i++ ) {
var elems = document.getElementsByTagName("div");
- ret = elems[elems.length-1].nodeType;
+ for (var j = 0, len = elems.length; j < len; j++) {
vsm 2012/03/28 18:00:14 Please don't change this file. It's the unmodifie
Jacob 2012/03/28 21:01:31 Done.
+ ret = elems[j].hidden;
+ }
}
});
test( "getElementsByTagName(p)", function(){
for ( var i = 0; i < num; i++ ) {
var elems = document.getElementsByTagName("p");
- ret = elems[elems.length-1].nodeType;
+ for (var j = 0, len = elems.length; j < len; j++) {
+ ret = elems[j].hidden;
+ }
}
});
test( "getElementsByTagName(a)", function(){
for ( var i = 0; i < num; i++ ) {
var elems = document.getElementsByTagName("a");
- ret = elems[elems.length-1].nodeType;
+ for (var j = 0, len = elems.length; j < len; j++) {
+ ret = elems[j].hidden;
+ }
}
});
test( "getElementsByTagName(*)", function(){
for ( var i = 0; i < num; i++ ) {
var elems = document.getElementsByTagName("*");
- ret = elems[elems.length-1].nodeType;
+ for (var j = 0, len = elems.length; j < len; j++) {
+ ret = elems[j].hidden;
+ }
}
});
test( "getElementsByTagName (not in document)", function(){
for ( var i = 0; i < num; i++ ) {
var elems = document.getElementsByTagName("strong");
- ret = elems.length == 0;
+ for (var j = 0, len = elems.length; j < len; j++) {
+ ret = elems[j].hidden;
+ }
}
});

Powered by Google App Engine
This is Rietveld 408576698