[Mac] Have BaseBubbleController dismiss bubbles when they would lose key state on 10.8.

[Mac] Have BaseBubbleController dismiss bubbles when they would lose key state on 10.8.

On 10.8, parent window key state sharing has changed semantic meaning to also 
include when the NSWindowDidResignKeyNotification is sent. This change adds two 
event taps, in the same manner as NSPopover does (c.f. bug for details), to 
properly dismiss bubble windows.

BUG=116179
TEST=On 10.8, open the bookmark bubble, extension bubbles, and the page info bubble. They are all dismissed wh
en you click outside the window or switch applications.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128106

[Nico, 2012-03-20 16:18:40]

LGTM

Can you think of any way we could make BaseBubbleViewController use an NSPopover
when on 10.7+? If we remove the InfoBubbleView* outlet and instead implicitly
create that in code on 10.6-, it might be doable.

http://codereview.chromium.org/9732012/diff/1005/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right):

http://codereview.chromium.org/9732012/diff/1005/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:224: [self
registerKeyStateEventTap];
:-/

[Robert Sesek, 2012-03-21 21:55:12]

On 2012/03/20 16:18:40, Nico wrote:
> Can you think of any way we could make BaseBubbleViewController use an
NSPopover
> when on 10.7+? If we remove the InfoBubbleView* outlet and instead implicitly
> create that in code on 10.6-, it might be doable.

I have a few ideas, but I'm hesitant to do that until we have 10.7
infrastructure to test that kind of stuff and ensure it continues to work.

http://codereview.chromium.org/9732012/diff/1005/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right):

http://codereview.chromium.org/9732012/diff/1005/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:224: [self
registerKeyStateEventTap];
On 2012/03/20 16:18:40, Nico wrote:
> :-/

Yeah, but calling super for this method turned out to be difficult. So meh :-/.

[commit-bot: I haz the power, 2012-03-21 22:00:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/9732012/10001

[commit-bot: I haz the power, 2012-03-21 23:43:27]

Change committed as 128106