Issue 9728006: Some compile time constants were not properly reporting static type warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9728006: Some compile time constants were not properly reporting static type warnings (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Some compile time constants were not properly reporting static type warnings http://code.google.com/p/dart/issues/detail?id=1957 Committed: https://code.google.com/p/dart/source/detail?r=5654

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scheglov

8 years, 9 months ago (2012-03-19 19:17:48 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9728006/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/9728006/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1730:
checkAssignable(node, node.getElement().getType(),
node.getElement().getConstantType());
indentation

Expand Messages | Collapse Messages