Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 9728006: Some compile time constants were not properly reporting static type warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
index ffc02d776481810d1750ada1f87b01c1776c0d5e..2d1919cbaa21bcff631d20cd69fc563373c1dd71 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
@@ -638,7 +638,8 @@ public class Resolver {
resolve(expression);
// Now, this constant has a type. Save it for future reference.
Element element = node.getElement();
- if (expression.getType() != null) {
+ if (expression.getType() != null
+ && element.getType().equals(typeProvider.getDynamicType())) {
Elements.setType(element, expression.getType());
}
} else if (isFinal) {

Powered by Google App Engine
This is Rietveld 408576698