extensions/renderer/guest_view/guest_view_internal_custom_bindings.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: address all comments from Nasko and Charlie, minus is_loading Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/guest_view/extensions_guest_view_container.cc ('K') | « extensions/renderer/guest_view/guest_view_container.cc ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('j') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

index b28634f0f49685a0f254b3d9a369baf53f6fd69e..f0d9c75794cdd356ac252bdd7328de84b92d1e61 100644

--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

@@ -50,6 +50,9 @@ class GuestViewInternalCustomBindings : public ObjectBackedNativeHandler {

void RegisterDestructionCallback(

const v8::FunctionCallbackInfo<v8::Value>& args);

+ void AttachIframeGuest(const v8::FunctionCallbackInfo<v8::Value>& args);

+ void IsSitePerProcess(const v8::FunctionCallbackInfo<v8::Value>& args);

// RegisterElementResizeCallback registers a JavaScript callback function to

// be called when the element is resized. RegisterElementResizeCallback takes

// a single parameter, |callback|.