extensions/renderer/guest_view/guest_view_container.cc - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_container.cc

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: address all comments from Nasko and Charlie, minus is_loading Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/guest_view/extensions_guest_view_container.cc ('K') | « extensions/renderer/guest_view/guest_view_container.h ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.h » ('j') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_container.cc

diff --git a/extensions/renderer/guest_view/guest_view_container.cc b/extensions/renderer/guest_view/guest_view_container.cc

index d09fa0046af2e26f9fc17763dfa9c0d07b79e533..00b8916b521dc761b68df692bfc0911e27c586a0 100644

--- a/extensions/renderer/guest_view/guest_view_container.cc

+++ b/extensions/renderer/guest_view/guest_view_container.cc

@@ -48,9 +48,9 @@ void GuestViewContainer::RenderFrameLifetimeObserver::OnDestruct() {

}

GuestViewContainer::GuestViewContainer(content::RenderFrame* render_frame)

- : element_instance_id_(guest_view::kInstanceIDNone),

- render_frame_(render_frame),

- ready_(false) {

+ : ready_(false),

+ element_instance_id_(guest_view::kInstanceIDNone),

+ render_frame_(render_frame) {

render_frame_lifetime_observer_.reset(

new RenderFrameLifetimeObserver(this, render_frame_));

}