Chromium Code Reviews
Help | Chromium Project | Sign in
(247)

Issue 9722041: Insert explicit deoptimization for named loads that have "uninitialized" type feedback. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by fschneider
Modified:
2 years ago
Reviewers:
Jakob
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Insert explicit deoptimization for named loads that have "uninitialized" type feedback.

We already do this for binary-ops, unary-ops and comparisons. Typefeedback for named loads can now also
be in "uninitialized" state which means that the corresponding load IC was never executed.
Committed: https://code.google.com/p/v8/source/detail?r=11087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Lint Patch
M src/ast.h View 3 chunks +3 lines, -0 lines 0 comments 0 errors Download
M src/ast.cc View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M src/hydrogen.cc View 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M src/type-info.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M src/type-info.cc View 2 chunks +12 lines, -1 line 0 comments 0 errors Download
M test/cctest/test-log-stack-tracer.cc View 2 chunks +4 lines, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
fschneider
2 years ago #1
Jakob
2 years ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434