Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: src/ast.cc

Issue 9722041: Insert explicit deoptimization for named loads that have "uninitialized" type feedback. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 bool FunctionDeclaration::IsInlineable() const { 392 bool FunctionDeclaration::IsInlineable() const {
393 return false; 393 return false;
394 } 394 }
395 395
396 396
397 // ---------------------------------------------------------------------------- 397 // ----------------------------------------------------------------------------
398 // Recording of type feedback 398 // Recording of type feedback
399 399
400 void Property::RecordTypeFeedback(TypeFeedbackOracle* oracle) { 400 void Property::RecordTypeFeedback(TypeFeedbackOracle* oracle) {
401 // Record type feedback from the oracle in the AST. 401 // Record type feedback from the oracle in the AST.
402 is_uninitialized_ = oracle->LoadIsUninitialized(this);
403 if (is_uninitialized_) return;
404
402 is_monomorphic_ = oracle->LoadIsMonomorphicNormal(this); 405 is_monomorphic_ = oracle->LoadIsMonomorphicNormal(this);
403 receiver_types_.Clear(); 406 receiver_types_.Clear();
404 if (key()->IsPropertyName()) { 407 if (key()->IsPropertyName()) {
405 if (oracle->LoadIsBuiltin(this, Builtins::kLoadIC_ArrayLength)) { 408 if (oracle->LoadIsBuiltin(this, Builtins::kLoadIC_ArrayLength)) {
406 is_array_length_ = true; 409 is_array_length_ = true;
407 } else if (oracle->LoadIsBuiltin(this, Builtins::kLoadIC_StringLength)) { 410 } else if (oracle->LoadIsBuiltin(this, Builtins::kLoadIC_StringLength)) {
408 is_string_length_ = true; 411 is_string_length_ = true;
409 } else if (oracle->LoadIsBuiltin(this, 412 } else if (oracle->LoadIsBuiltin(this,
410 Builtins::kLoadIC_FunctionPrototype)) { 413 Builtins::kLoadIC_FunctionPrototype)) {
411 is_function_prototype_ = true; 414 is_function_prototype_ = true;
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
1153 OS::SNPrintF(buffer, "%d", Smi::cast(*handle_)->value()); 1156 OS::SNPrintF(buffer, "%d", Smi::cast(*handle_)->value());
1154 str = arr; 1157 str = arr;
1155 } else { 1158 } else {
1156 str = DoubleToCString(handle_->Number(), buffer); 1159 str = DoubleToCString(handle_->Number(), buffer);
1157 } 1160 }
1158 return FACTORY->NewStringFromAscii(CStrVector(str)); 1161 return FACTORY->NewStringFromAscii(CStrVector(str));
1159 } 1162 }
1160 1163
1161 1164
1162 } } // namespace v8::internal 1165 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698