Replace extension disabled infobar with a global error.

Replace extension disabled infobar with a global error.

Move disabled-extension interface to namespace extensions.

It looks like this:
http://dl.dropbox.com/u/27111995/Mocks/disable-dialog.png
http://dl.dropbox.com/u/27111995/Mocks/disable-menu.png

BUG=108202
TEST=install extension, update to version that requires additional permissions. Accept upgrade. Uninstall manually from chrome://extensions. Don't crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127887

[Yoyo Zhou, 2012-03-16 22:09:06]

mpcomplete: please review for extensions
sail: please review for use of GlobalError

[sail, 2012-03-16 22:21:43]

Looks good!
Could you also add unit tests for the new bubble? Here are some examples you can
follow:
http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/sync/sync_gl...
http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/protector/pr...

http://codereview.chromium.org/9718008/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_disabled_ui.cc (right):

http://codereview.chromium.org/9718008/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_disabled_ui.cc:118: base::Unretained(this),
can you use a weak ptr instead?

[Aaron Boodman, 2012-03-16 22:36:03]

UI feedback:

1) Multiple menu items should be possible if multiple extensions are in this
state.
2) I'm having trouble coming up with good, non-confusing text for the menu item.
The best I have come up with so far is "AdBlock requires new permissions"

I think perhaps this indicates we should skip to phase 2 as rapidly as possible.
But since this is purely an improvement to what we have now, you should keep
going with this change.

[Matt Perry, 2012-03-16 23:52:06]

lgtm

http://codereview.chromium.org/9718008/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_disabled_ui.h (right):

http://codereview.chromium.org/9718008/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_disabled_ui.h:19: class
ExtensionDisabledGlobalError : public GlobalError,
Can this go in the .cc file? It's not part of the public API.

[Yoyo Zhou, 2012-03-20 07:04:08]

I added a browsertest for the error bubble. Unfortunately I can't call its
Accept/Cancel methods because those bring up dialog prompts, so I circumvent
them.

I changed the strings so that it's "My FIrst Extension requires new permissions"
in both the menu entry and the bubble 'title'. There are now multiple menu items
(one per disabled extension).

https://chromiumcodereview.appspot.com/9718008/diff/1/chrome/browser/extensio...
File chrome/browser/extensions/extension_disabled_ui.cc (right):

https://chromiumcodereview.appspot.com/9718008/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_disabled_ui.cc:118: base::Unretained(this),
On 2012/03/16 22:21:43, sail wrote:
> can you use a weak ptr instead?

It looks like I don't need to PostTask after all.

https://chromiumcodereview.appspot.com/9718008/diff/1/chrome/browser/extensio...
File chrome/browser/extensions/extension_disabled_ui.h (right):

https://chromiumcodereview.appspot.com/9718008/diff/1/chrome/browser/extensio...
chrome/browser/extensions/extension_disabled_ui.h:19: class
ExtensionDisabledGlobalError : public GlobalError,
On 2012/03/16 23:52:06, Matt Perry wrote:
> Can this go in the .cc file? It's not part of the public API.

Done.

[Matt Perry, 2012-03-20 17:05:04]

lgtm

https://chromiumcodereview.appspot.com/9718008/diff/6001/chrome/browser/exten...
File chrome/browser/extensions/extension_disabled_ui_browsertest.cc (right):

https://chromiumcodereview.appspot.com/9718008/diff/6001/chrome/browser/exten...
chrome/browser/extensions/extension_disabled_ui_browsertest.cc:34:
ExtensionService* service = browser()->profile()->GetExtensionService();
nit: this is just service_

[Yoyo Zhou, 2012-03-20 17:45:02]

https://chromiumcodereview.appspot.com/9718008/diff/6001/chrome/browser/exten...
File chrome/browser/extensions/extension_disabled_ui_browsertest.cc (right):

https://chromiumcodereview.appspot.com/9718008/diff/6001/chrome/browser/exten...
chrome/browser/extensions/extension_disabled_ui_browsertest.cc:34:
ExtensionService* service = browser()->profile()->GetExtensionService();
On 2012/03/20 17:05:04, Matt Perry wrote:
> nit: this is just service_

Done.

[sail, 2012-03-20 19:50:07]

LGTM!

[Yoyo Zhou, 2012-03-20 23:29:43]

FYI, I found a couple of tests in extension_management_browsertest that had been
testing this already (which was where I got the helper methods from to begin
with), so rather than duplicate the tests, I deleted the old ones, taking a few
more bits into the new ones.

[Yoyo Zhou, 2012-03-20 23:40:27]

pkasting: could you rubber-stamp for chrome/browser/ui? Thanks.

[Peter Kasting, 2012-03-20 23:42:13]

LGTM

[commit-bot: I haz the power, 2012-03-20 23:45:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/9718008/18001

[commit-bot: I haz the power, 2012-03-21 02:48:12]

Change committed as 127887