Issue 9706031: Settings: Fix a few overlays that set min-width on the list directly.

Issue 9706031: Settings: Fix a few overlays that set min-width on the list directly. (Closed)

Created:
8 years, 9 months ago by James Hawkins

Modified:
8 years, 9 months ago

Reviewers:
csilv, Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Settings: Fix a few overlays that set min-width on the list directly. BUG=118070 TEST=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126727

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -33 lines)			Patch
M	chrome/browser/resources/options2/autofill_options.css	View	1 chunk	+2 lines, -3 lines	2 comments	Download
M	chrome/browser/resources/options2/cookies_view.css	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options2/cookies_view.js	View	3 chunks	+1 line, -19 lines	0 comments	Download
M	chrome/browser/resources/options2/startup_overlay.css	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/overlay.js	View	2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

https://chromiumcodereview.appspot.com/9706031/diff/1/chrome/browser/resources/options2/autofill_options.css File chrome/browser/resources/options2/autofill_options.css (right): https://chromiumcodereview.appspot.com/9706031/diff/1/chrome/browser/resources/options2/autofill_options.css#newcode6 chrome/browser/resources/options2/autofill_options.css:6: min-width: 550px; why is this min-width? when can the ...

8 years, 9 months ago (2012-03-15 01:00:58 UTC) #3

James Hawkins

8 years, 9 months ago (2012-03-15 01:18:16 UTC) #4

https://chromiumcodereview.appspot.com/9706031/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/autofill_options.css (right):

https://chromiumcodereview.appspot.com/9706031/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/autofill_options.css:6: min-width: 550px;
On 2012/03/15 01:00:58, Evan Stade wrote:
> why is this min-width? when can the autofill options dialog expand wider than
> this?

When a list item grows larger than the width of the list.  The list item being
the profile summary.  After just now playing around with this, we should
probably use a sensible max-width here as well.

Expand Messages | Collapse Messages