Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: chrome/browser/resources/options2/cookies_view.js

Issue 9706031: Settings: Fix a few overlays that set min-width on the list directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/cookies_view.js
diff --git a/chrome/browser/resources/options2/cookies_view.js b/chrome/browser/resources/options2/cookies_view.js
index d6e33d47838bf1471f0732f72f6edef6cf8eddfc..ce02c6607eee5c25e72a89160cbc4a4d0b2027e8 100644
--- a/chrome/browser/resources/options2/cookies_view.js
+++ b/chrome/browser/resources/options2/cookies_view.js
@@ -45,12 +45,11 @@ cr.define('options', function() {
this.handleSearchQueryChange_.bind(this));
$('remove-all-cookies-button').onclick = function(e) {
- chrome.send('removeAllCookies', []);
+ chrome.send('removeAllCookies');
};
var cookiesList = $('cookies-list');
options.CookiesList.decorate(cookiesList);
- window.addEventListener('resize', this.handleResize_.bind(this));
this.addEventListener('visibleChange', this.handleVisibleChange_);
@@ -94,8 +93,6 @@ cr.define('options', function() {
if (!this.visible)
return;
- // Resize the cookies list whenever the options page becomes visible.
- this.handleResize_(null);
if (!this.initialized_) {
this.initialized_ = true;
this.searchCookie();
@@ -105,21 +102,6 @@ cr.define('options', function() {
$('cookies-search-box').focus();
},
-
- /**
- * Handler for when the window changes size. Resizes the cookies list to
- * match the window height.
- * @param {?Event} e Window resize event, or null if called directly.
- * @private
- */
- handleResize_: function(e) {
- if (!this.visible)
- return;
- var cookiesList = $('cookies-list');
- // 25 pixels from the window bottom seems like a visually pleasing amount.
- var height = window.innerHeight - cookiesList.offsetTop - 25;
- cookiesList.style.height = height + 'px';
- },
};
// CookiesViewHandler callbacks.

Powered by Google App Engine
This is Rietveld 408576698