Issue 9705097: Revert 127146 - Add Extension Keybinding test for page actions and port the PageAction keybindings …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9705097: Revert 127146 - Add Extension Keybinding test for page actions and port the PageAction keybindings … (Closed)

Created:
8 years, 9 months ago by Finnur

Modified:
8 years, 9 months ago

Reviewers:
Finnur

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 127146 - Add Extension Keybinding test for page actions and port the PageAction keybindings to GTK. Failed on ChromeOS bots, even though it passed on the try bots... :/ BUG=27702 TEST=KeybindingApiTest.PageAction Review URL: https://chromiumcodereview.appspot.com/9693047 TBR=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127149

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -213 lines)			Patch
M	chrome/browser/extensions/extension_keybinding_apitest.cc	View	5 chunks	+13 lines, -46 lines	0 comments	Download
MM	chrome/browser/ui/gtk/location_bar_view_gtk.h	View	5 chunks	+0 lines, -37 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	9 chunks	+1 line, -93 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/test/data/extensions/api_test/keybinding/page_action/background.js	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/keybinding/page_action/manifest.json	View	1 chunk	+0 lines, -21 lines	0 comments	Download

Total messages: 1 (0 generated)