Unknown options in extension manifest file are silently ignored

chrome/browser/ui/webui/options/extension_settings_handler.cc

Index: chrome/browser/ui/webui/options/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/extension_settings_handler.cc b/chrome/browser/ui/webui/options/extension_settings_handler.cc
index 6ea248dfb01c52818bee6b02c2f36348782a0b28..d29ff9d3cc861b737fc9d646eed1c44e5a9891cb 100644
--- a/chrome/browser/ui/webui/options/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/extension_settings_handler.cc
@@ -544,6 +544,8 @@ void ExtensionSettingsHandler::GetLocalizedValues(
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_PATH));
   localized_strings->SetString("extensionSettingsInspectViews",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSPECT_VIEWS));
+  localized_strings->SetString("extensionSettingsExtensionUnrecognizedKeys",
+      l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNRECOGNIZED_KEYS));
   localized_strings->SetString("viewIncognito",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INCOGNITO));
   localized_strings->SetString("extensionSettingsEnable",
@@ -691,6 +693,19 @@ DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
                              extension->location() == Extension::LOAD);
   extension_data->SetBoolean("is_hosted_app", extension->is_hosted_app());
 
+  // Add unrecognized manifest keys

[James Hawkins, 2012/04/08 20:33:23]

nit: Add period.

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+  const std::vector<const std::string*>* unrecognized_keys_vec;

[not at google - send to devlin, 2012/04/10 02:02:32]

just call it "unrecognized_keys" or even "keys".

[not at google - send to devlin, 2012/04/10 02:02:32]

also, a bit of a nit, but since this is a really long method and this variable
is just temporary, perhaps surround the whole block in a { } scope?

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+  if (extension->HasUnrecognizedManifestKeys(&unrecognized_keys_vec)) {
+    ListValue* unrecognized_keys = new ListValue;

[not at google - send to devlin, 2012/04/10 02:02:32]

nit: ListValue not ListValue()

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+    for (std::vector<const std::string*>::const_iterator iter =
+            unrecognized_keys_vec->begin();
+         iter != unrecognized_keys_vec->end();
+         ++iter) {

[not at google - send to devlin, 2012/04/09 13:01:54]

nit: call iterators "it" or "i", it's more concise, and if it can fit on 2 lines
then do that (put the ++i on the line above)

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+      unrecognized_keys->Append(Value::CreateStringValue(**iter));
+    }
+    extension_data->Set("unrecognizedKeys", unrecognized_keys);
+  }
+
   // Determine the sort order: Extensions loaded through --load-extensions show
   // up at the top. Disabled extensions show up at the bottom.
   if (extension->location() == Extension::LOAD)