Unknown options in extension manifest file are silently ignored

chrome/browser/ui/webui/options/extension_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/extension_settings_handler.h"
 
 #include "base/auto_reset.h"
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 526 matching lines @@
       l10n_util::GetStringUTF16(IDS_GET_MORE_EXTENSIONS));
   localized_strings->SetString("extensionSettingsGetMoreExtensionsUrl",
       ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
           GURL(extension_urls::GetWebstoreLaunchURL())).spec()));
   localized_strings->SetString("extensionSettingsExtensionId",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_ID));
   localized_strings->SetString("extensionSettingsExtensionPath",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_PATH));
   localized_strings->SetString("extensionSettingsInspectViews",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSPECT_VIEWS));
+  localized_strings->SetString("extensionSettingsExtensionUnrecognizedKeys",
+      l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNRECOGNIZED_KEYS));
   localized_strings->SetString("viewIncognito",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INCOGNITO));
   localized_strings->SetString("extensionSettingsEnable",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_ENABLE));
   localized_strings->SetString("extensionSettingsEnabled",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_ENABLED));
   localized_strings->SetString("extensionSettingsRemove",
     l10n_util::GetStringUTF16(IDS_EXTENSIONS_REMOVE));
   localized_strings->SetString("extensionSettingsEnableIncognito",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_ENABLE_INCOGNITO));
@@ skipping 127 matching lines @@
   extension_data->SetBoolean("wantsFileAccess", extension->wants_file_access());
   extension_data->SetBoolean("allowFileAccess",
       service ? service->AllowFileAccess(extension) : false);
   extension_data->SetBoolean("allow_activity",
       enabled && CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableExtensionActivityUI));
   extension_data->SetBoolean("allow_reload",
                              extension->location() == Extension::LOAD);
   extension_data->SetBoolean("is_hosted_app", extension->is_hosted_app());
 
+  // Add unrecognized manifest keys

[James Hawkins, 2012/04/08 20:33:23]

nit: Add period.

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+  const std::vector<const std::string*>* unrecognized_keys_vec;

[not at google - send to devlin, 2012/04/10 02:02:32]

just call it "unrecognized_keys" or even "keys".

[not at google - send to devlin, 2012/04/10 02:02:32]

also, a bit of a nit, but since this is a really long method and this variable
is just temporary, perhaps surround the whole block in a { } scope?

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+  if (extension->HasUnrecognizedManifestKeys(&unrecognized_keys_vec)) {
+    ListValue* unrecognized_keys = new ListValue;

[not at google - send to devlin, 2012/04/10 02:02:32]

nit: ListValue not ListValue()

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+    for (std::vector<const std::string*>::const_iterator iter =
+            unrecognized_keys_vec->begin();
+         iter != unrecognized_keys_vec->end();
+         ++iter) {

[not at google - send to devlin, 2012/04/09 13:01:54]

nit: call iterators "it" or "i", it's more concise, and if it can fit on 2 lines
then do that (put the ++i on the line above)

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+      unrecognized_keys->Append(Value::CreateStringValue(**iter));
+    }
+    extension_data->Set("unrecognizedKeys", unrecognized_keys);
+  }
+
   // Determine the sort order: Extensions loaded through --load-extensions show
   // up at the top. Disabled extensions show up at the bottom.
   if (extension->location() == Extension::LOAD)
     extension_data->SetInteger("order", 1);
   else
     extension_data->SetInteger("order", 2);
 
   if (!extension->options_url().is_empty() && enabled)
     extension_data->SetString("options_url", extension->options_url().spec());
 
@@ skipping 78 matching lines @@
         chrome::VIEW_TYPE_EXTENSION_DIALOG == host_type)
       continue;
 
     GURL url = host->GetDelegate()->GetURL();
     content::RenderProcessHost* process = host->GetProcess();
     result->push_back(
         ExtensionPage(url, process->GetID(), host->GetRoutingID(),
                       process->GetBrowserContext()->IsOffTheRecord()));
   }
 }