Issue 9705020: Fix wrapping of receiver for non-strict callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9705020: Fix wrapping of receiver for non-strict callbacks. (Closed)

Created:
8 years, 9 months ago by Michael Starzinger

Modified:
8 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix wrapping of receiver for non-strict callbacks. R=rossberg@chromium.org BUG=v8:1973 TEST=mjsunit/regress/regress-1973 Committed: https://code.google.com/p/v8/source/detail?r=11050

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -9 lines)			Patch
M	src/objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/getter-in-value-prototype.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-1973.js	View	1	2 chunks	+24 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

LTGM with comment. https://chromiumcodereview.appspot.com/9705020/diff/1/test/mjsunit/regress/regress-1973.js File test/mjsunit/regress/regress-1973.js (right): https://chromiumcodereview.appspot.com/9705020/diff/1/test/mjsunit/regress/regress-1973.js#newcode31 test/mjsunit/regress/regress-1973.js:31: function TestAccessorWrapping(prototype, primitive) { Instead of ...

8 years, 9 months ago (2012-03-14 17:34:52 UTC) #2

Added new patch set. Landed.

Expand Messages | Collapse Messages

Issue 9705020: Fix wrapping of receiver for non-strict callbacks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Messages