Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/objects.cc

Issue 9705020: Fix wrapping of receiver for non-strict callbacks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Andreas Rossberg. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/getter-in-value-prototype.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 // Handle stepping into a getter if step into is active. 281 // Handle stepping into a getter if step into is active.
282 // TODO(rossberg): should this apply to getters that are function proxies? 282 // TODO(rossberg): should this apply to getters that are function proxies?
283 if (debug->StepInActive() && fun->IsJSFunction()) { 283 if (debug->StepInActive() && fun->IsJSFunction()) {
284 debug->HandleStepIn( 284 debug->HandleStepIn(
285 Handle<JSFunction>::cast(fun), Handle<Object>::null(), 0, false); 285 Handle<JSFunction>::cast(fun), Handle<Object>::null(), 0, false);
286 } 286 }
287 #endif 287 #endif
288 288
289 bool has_pending_exception; 289 bool has_pending_exception;
290 Handle<Object> result = 290 Handle<Object> result =
291 Execution::Call(fun, self, 0, NULL, &has_pending_exception); 291 Execution::Call(fun, self, 0, NULL, &has_pending_exception, true);
292 // Check for pending exception and return the result. 292 // Check for pending exception and return the result.
293 if (has_pending_exception) return Failure::Exception(); 293 if (has_pending_exception) return Failure::Exception();
294 return *result; 294 return *result;
295 } 295 }
296 296
297 297
298 // Only deal with CALLBACKS and INTERCEPTOR 298 // Only deal with CALLBACKS and INTERCEPTOR
299 MaybeObject* JSObject::GetPropertyWithFailedAccessCheck( 299 MaybeObject* JSObject::GetPropertyWithFailedAccessCheck(
300 Object* receiver, 300 Object* receiver,
301 LookupResult* result, 301 LookupResult* result,
(...skipping 12654 matching lines...) Expand 10 before | Expand all | Expand 10 after
12956 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 12956 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
12957 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 12957 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
12958 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 12958 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
12959 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 12959 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
12960 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 12960 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
12961 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 12961 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
12962 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 12962 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
12963 } 12963 }
12964 12964
12965 } } // namespace v8::internal 12965 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/getter-in-value-prototype.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698