HostResolver is exposed to Native Client.

HostResolver is exposed to Native Client.

BUG=114225
TEST=PPAPINaClTest.HostResolverPrivate_*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127443

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127668

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128199

[ygorshenin1, 2012-03-16 09:24:57]

+ Dmitry

[bbudge, 2012-03-16 16:50:40]

lgtm w/nit

http://codereview.chromium.org/9704080/diff/1/ppapi/ppapi_sources.gypi
File ppapi/ppapi_sources.gypi (right):

http://codereview.chromium.org/9704080/diff/1/ppapi/ppapi_sources.gypi#newcod...
ppapi/ppapi_sources.gypi:402: 'tests/test_host_resolver_private.cc',
You could remove these here.

[brettw, 2012-03-16 19:36:23]

LGTM rubberstamp.

[bbudge, 2012-03-16 20:16:01]

Yuri, I was checking to make sure that we don't allow arbitrary apps to get this
private interface and I don't understand how we restrict this. I also see that
there are other private interfaces.

Right now, we whitelist apps that are allowed to get 'dev' interfaces and we
probably need to do the same for any apps that use this. Also, in that case,
you'd have to check for 'private' in the interface name, as we do for 'dev' (see
browser_globals.cc).

[ygorshenin1, 2012-03-19 07:38:41]

For TCP/UDP and HostResolver interfaces exists protection based on  manifest
associated with a given app. And now exists a list of allowed apps. Look at
http://code.google.com/p/chromium/issues/detail?id=116225.

On 2012/03/16 20:16:01, bbudge1 wrote:
> Yuri, I was checking to make sure that we don't allow arbitrary apps to get
this
> private interface and I don't understand how we restrict this. I also see that
> there are other private interfaces.
> 
> Right now, we whitelist apps that are allowed to get 'dev' interfaces and we
> probably need to do the same for any apps that use this. Also, in that case,
> you'd have to check for 'private' in the interface name, as we do for 'dev'
(see
> browser_globals.cc).

[ygorshenin1, 2012-03-19 08:16:05]

Thanks!

http://codereview.chromium.org/9704080/diff/1/ppapi/ppapi_sources.gypi
File ppapi/ppapi_sources.gypi (right):

http://codereview.chromium.org/9704080/diff/1/ppapi/ppapi_sources.gypi#newcod...
ppapi/ppapi_sources.gypi:402: 'tests/test_host_resolver_private.cc',
On 2012/03/16 16:50:40, bbudge1 wrote:
> You could remove these here.

Done.

[bbudge, 2012-03-19 13:21:58]

OK, that should be fine then.
On 2012/03/19 07:38:41, ygorshenin1 wrote:
> For TCP/UDP and HostResolver interfaces exists protection based on  manifest
> associated with a given app. And now exists a list of allowed apps. Look at
> http://code.google.com/p/chromium/issues/detail?id=116225.
> 
> On 2012/03/16 20:16:01, bbudge1 wrote:
> > Yuri, I was checking to make sure that we don't allow arbitrary apps to get
> this
> > private interface and I don't understand how we restrict this. I also see
that
> > there are other private interfaces.
> > 
> > Right now, we whitelist apps that are allowed to get 'dev' interfaces and we
> > probably need to do the same for any apps that use this. Also, in that case,
> > you'd have to check for 'private' in the interface name, as we do for 'dev'
> (see
> > browser_globals.cc).

[commit-bot: I haz the power, 2012-03-22 10:23:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/9704080/30001

[commit-bot: I haz the power, 2012-03-22 10:23:22]

Presubmit check for 9704080-30001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc, line 1674, 87
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc, line 1716, 89
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc, line 1750, 86
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc, line 3211, 87
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc, line 3212, 103
chars

Presubmit checks took 2.2s to calculate.