Disable the optimizations replacing aggregates with scalars for Android

build/common.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ab23f942ae60ef2398b4a70740a05e64290dc68c..a74b95deaf6eec8777cc245bc2f9054af02dfa32 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1948,9 +1948,19 @@
                     ],
                   }],
                   ['OS=="android"', {
-                    # The following flags are derived from what Android uses
-                    # by default when building for arm.
-                    'cflags': [ '-Wno-psabi', ],
+                    # Most of the following flags are derived from what Android
+                    # uses by default when building for arm, reference for which
+                    # can be found in the following file in the Android NDK:
+                    # toolchains/arm-linux-androideabi-4.4.3/setup.mk
+                    'cflags': [
+                      # The tree-sra optimization (scalar replacement for
+                      # aggregates enabling subsequent optimizations) leads to
+                      # invalid code generation when using the Android NDK's
+                      # compiler. This can be verified using TestWebKitAPI's

[John Grabowski, 2012/03/15 17:55:32]

specify which version of the compiler has this problem.
be clear about what test fails so if we have a new compiler we can easily see if
things are fixed.

[Peter Beverloo, 2012/03/15 18:00:47]

I clarified that this applies to NDK r5-r7 (possibly earlier versions as well,
but I didn't verify that). The next line names the actual test-case which fails
(WTF.Checked_int8_t), getting clearer than this will be hard.

+                      # WTF.Checked_int8_t test.
+                      '-fno-tree-sra',
+                      '-Wno-psabi',
+                    ],
                     'conditions': [
                       ['arm_thumb == 1', {
                         # Android toolchain doesn't support -mimplicit-it=thumb