Disable the optimizations replacing aggregates with scalars for Android

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 1930 matching lines @@
                     ],
                     'conditions': [
                       ['arm_neon==1', {
                         'cflags': [ '-mfpu=neon', ],
                       }, {
                         'cflags': [ '-mfpu=<(arm_fpu)', ],
                       }]
                     ],
                   }],
                   ['OS=="android"', {
-                    # The following flags are derived from what Android uses
-                    # by default when building for arm.
-                    'cflags': [ '-Wno-psabi', ],
+                    # Most of the following flags are derived from what Android
+                    # uses by default when building for arm, reference for which
+                    # can be found in the following file in the Android NDK:
+                    # toolchains/arm-linux-androideabi-4.4.3/setup.mk
+                    'cflags': [
+                      # The tree-sra optimization (scalar replacement for
+                      # aggregates enabling subsequent optimizations) leads to
+                      # invalid code generation when using the Android NDK's
+                      # compiler. This can be verified using TestWebKitAPI's

[John Grabowski, 2012/03/15 17:55:32]

specify which version of the compiler has this problem.
be clear about what test fails so if we have a new compiler we can easily see if
things are fixed.

[Peter Beverloo, 2012/03/15 18:00:47]

I clarified that this applies to NDK r5-r7 (possibly earlier versions as well,
but I didn't verify that). The next line names the actual test-case which fails
(WTF.Checked_int8_t), getting clearer than this will be hard.

+                      # WTF.Checked_int8_t test.
+                      '-fno-tree-sra',
+                      '-Wno-psabi',
+                    ],
                     'conditions': [
                       ['arm_thumb == 1', {
                         # Android toolchain doesn't support -mimplicit-it=thumb
                         'cflags!': [ '-Wa,-mimplicit-it=thumb', ],
                         'cflags': [ '-mthumb-interwork', ],
                       }],
                       ['armv7==0', {
                         # Flags suitable for Android emulator
                         'cflags': [
                           '-march=armv5te',
@@ skipping 930 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }