Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: runtime/bin/file_impl.dart

Issue 9703023: Fix some minor static type issues in dart:io implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/process_impl.dart » ('j') | runtime/bin/process_impl.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file_impl.dart
diff --git a/runtime/bin/file_impl.dart b/runtime/bin/file_impl.dart
index 479cea36b0a2fd12c872def397baff59ed31c39c..70af2ac491dfa79bcf107b8026aa19f1d133e496 100644
--- a/runtime/bin/file_impl.dart
+++ b/runtime/bin/file_impl.dart
@@ -489,7 +489,7 @@ class _File implements File {
});
}
- RandomAccessFile openSync([FileMode mode = FileMode.READ]) {
+ RandomAccessFile openSync(FileMode mode) {
Mads Ager (google) 2012/03/14 13:34:08 Why? I can't believe that this does not break oth
Bill Hesse 2012/03/14 13:46:49 The File interface already declares openSync this
Mads Ager (google) 2012/03/14 14:03:03 OK, could you check that all users of openSync pro
if (_asyncUsed) {
throw new FileIOException(
"Mixed use of synchronous and asynchronous API");
@@ -572,7 +572,7 @@ class _File implements File {
throw new FileIOException(
"Mixed use of synchronous and asynchronous API");
}
- var opened = openSync();
+ var opened = openSync(FileMode.READ);
var length = opened.lengthSync();
var result = new ByteArray(length);
var read = opened.readListSync(result, 0, length);
@@ -655,7 +655,7 @@ class _File implements File {
String get name() => _name;
- void set onError(void handler(String error)) {
+ void set onError(void handler(Exception error)) {
_onError = handler;
}
« no previous file with comments | « no previous file | runtime/bin/process_impl.dart » ('j') | runtime/bin/process_impl.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698