runtime/bin/process_impl.dart - Issue 9703023: Fix some minor static type issues in dart:io implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_impl.dart

Issue 9703023: Fix some minor static type issues in dart:io implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/process_impl.dart

diff --git a/runtime/bin/process_impl.dart b/runtime/bin/process_impl.dart

index 2fcdaabfc2ee5e64eb688fccdb64edf1c459a5f0..0cde81ff53b0833af358add9378af097dae63472 100644

--- a/runtime/bin/process_impl.dart

+++ b/runtime/bin/process_impl.dart

@@ -197,9 +197,9 @@ class _Process implements Process {

String _path;

ObjectArray<String> _arguments;

String _workingDirectory;

- Socket _in;

- Socket _out;

- Socket _err;

+ _Socket _in; // Private methods of _Socket are used.

Mads Ager (google) 2012/03/14 13:34:08 This is not just a comment on this line. move to a

Bill Hesse 2012/03/14 13:46:49 Done.

+ _Socket _out;

+ _Socket _err;

Socket _exitHandler;

int _pid;

bool _closed;

« runtime/bin/file_impl.dart ('K') | « runtime/bin/file_impl.dart ('k') | runtime/bin/socket_impl.dart » ('j') | runtime/bin/socket_impl.dart » ('J')