Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 9702042: Remove canRecoverFromContextLoss logic (Closed)

Created:
8 years, 9 months ago by jamesr
Modified:
8 years, 9 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove canRecoverFromContextLoss logic Canvas now queries if the host can lose a context arbitrarily seperately from context creation, so this logic is redundant. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
Once http://trac.webkit.org/changeset/110716 rolls into Chromium, this logic will be dead (probably not a great idea ...
8 years, 9 months ago (2012-03-14 21:39:38 UTC) #1
apatrick_chromium
Presumably it's okay if we lose the UMA_HISTOGRAM stats? LGTM if so.
8 years, 9 months ago (2012-03-14 21:52:04 UTC) #2
jamesr
On 2012/03/14 21:52:04, apatrick_chromium wrote: > Presumably it's okay if we lose the UMA_HISTOGRAM stats? ...
8 years, 9 months ago (2012-03-14 21:52:45 UTC) #3
apatrick_chromium
On 2012/03/14 21:52:45, jamesr wrote: > On 2012/03/14 21:52:04, apatrick_chromium wrote: > > Presumably it's ...
8 years, 9 months ago (2012-03-14 21:54:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9702042/1
8 years, 9 months ago (2012-03-14 22:28:42 UTC) #5
commit-bot: I haz the power
Try job failure for 9702042-1 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=8787 Step "update" is always ...
8 years, 9 months ago (2012-03-14 22:39:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9702042/1
8 years, 9 months ago (2012-03-14 23:08:47 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 00:37:28 UTC) #8
Try job failure for 9702042-1 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698