Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 9702041: Do not change video decoder collection unless it is indeed a media stream. (Closed)

Created:
8 years, 9 months ago by wjia(left Chromium)
Modified:
8 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Do not change video decoder collection unless it is indeed a media stream. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126775

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webkit/media/filter_helpers.cc View 2 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
wjia(left Chromium)
Just happen to see this. The correct order is to detect existence of media stream ...
8 years, 9 months ago (2012-03-14 21:52:01 UTC) #1
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/9702041/diff/1/webkit/media/filter_helpers.cc File webkit/media/filter_helpers.cc (right): https://chromiumcodereview.appspot.com/9702041/diff/1/webkit/media/filter_helpers.cc#newcode38 webkit/media/filter_helpers.cc:38: if (!client) I thought this was what prevented non-mediastreams ...
8 years, 9 months ago (2012-03-14 22:00:09 UTC) #2
wjia(left Chromium)
On 2012/03/14 22:00:09, Ami Fischman wrote: > https://chromiumcodereview.appspot.com/9702041/diff/1/webkit/media/filter_helpers.cc > File webkit/media/filter_helpers.cc (right): > > https://chromiumcodereview.appspot.com/9702041/diff/1/webkit/media/filter_helpers.cc#newcode38 ...
8 years, 9 months ago (2012-03-14 22:04:45 UTC) #3
Ami GONE FROM CHROMIUM
8 years, 9 months ago (2012-03-14 22:18:53 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698