Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: webkit/media/filter_helpers.cc

Issue 9702041: Do not change video decoder collection unless it is indeed a media stream. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/filter_helpers.cc
===================================================================
--- webkit/media/filter_helpers.cc (revision 126489)
+++ webkit/media/filter_helpers.cc (working copy)
@@ -38,6 +38,11 @@
if (!client)
Ami GONE FROM CHROMIUM 2012/03/14 22:00:09 I thought this was what prevented non-mediastreams
return false;
+ scoped_refptr<media::VideoDecoder> video_decoder = client->GetVideoDecoder(
+ url, message_loop_factory);
+ if (!video_decoder)
+ return false;
+
// Remove any "traditional" decoders (e.g. GpuVideoDecoder) from the
// collection.
// NOTE: http://crbug.com/110800 is about replacing this ad-hockery with
@@ -47,11 +52,6 @@
filter_collection->SelectVideoDecoder(&old_videodecoder);
} while (old_videodecoder);
- scoped_refptr<media::VideoDecoder> video_decoder = client->GetVideoDecoder(
- url, message_loop_factory);
- if (!video_decoder)
- return false;
-
filter_collection->AddVideoDecoder(video_decoder);
// TODO(vrk/wjia): Setting true for local_source is under the assumption
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698