Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 9702021: Unconditionally send Chrome and Chrome Frame events through ETW machinery. (Closed)

Created:
8 years, 9 months ago by grt (UTC plus 2)
Modified:
8 years, 9 months ago
CC:
chromium-reviews, amit, robertshield
Visibility:
Public.

Description

Unconditionally send Chrome and Chrome Frame events through ETW machinery. Previously, these components only registered themselves if CHROME_ETW_LOGGING was set in the environment. This is likely preventing the new log machinery in http://crrev.com/126240 from providing useful information on the main waterfall bots. Siggi: overall Brett: chrome/common BUG=none TEST=none R=siggi@chromium.org,brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -108 lines) Patch
M chrome/common/env_vars.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/env_vars.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/logging/win/file_logger.h View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/test/logging/win/file_logger.cc View 3 chunks +0 lines, -71 lines 0 comments Download
M chrome_frame/chrome_tab.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
8 years, 9 months ago (2012-03-14 14:32:21 UTC) #1
Sigurður Ásgeirsson
lgtm, thanks! The reason the environment snooping was added in the first place was a ...
8 years, 9 months ago (2012-03-14 14:43:47 UTC) #2
brettw
LGTM, I don't really have an opinion on this
8 years, 9 months ago (2012-03-14 16:05:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/9702021/1
8 years, 9 months ago (2012-03-14 18:44:26 UTC) #4
commit-bot: I haz the power
Try job failure for 9702021-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-14 21:55:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/9702021/1
8 years, 9 months ago (2012-03-14 22:28:27 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 00:13:19 UTC) #7
Try job failure for 9702021-1 (retry) (retry) on linux_rel for step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698