Unconditionally send Chrome and Chrome Frame events through ETW machinery.

chrome/test/logging/win/file_logger.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/logging/win/file_logger.h"
 
 #include <windows.h>
 #include <guiddef.h>
 #include <objbase.h>
 
 #include <ios>
 
 #include "base/debug/trace_event_win.h"
 #include "base/logging.h"
 #include "base/file_path.h"
 #include "base/logging_win.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/event_trace_consumer.h"
 #include "base/win/registry.h"
-#include "chrome/common/env_vars.h"
 
 namespace logging_win {
 
 namespace {
 
 const wchar_t kChromeTestSession[] = L"chrome_tests";
 
 // From chrome_tab.cc: {0562BFC3-2550-45b4-BD8E-A310583D3A6F}
 const GUID kChromeFrameProvider =
     { 0x562bfc3, 0x2550, 0x45b4,
@@ skipping 19 matching lines @@
   { &kChromeTraceProviderName, 255, 0 },
   { &kChromeFrameProvider, 255, 0 },
   { &kChromeTestsProvider, 255, 0 },
   { &base::debug::kChromeTraceProviderName, 255, 0 }
 };
 
 COMPILE_ASSERT((1 << arraysize(kProviders)) - 1 ==
                    FileLogger::kAllEventProviders,
                size_of_kProviders_is_inconsistent_with_kAllEventProviders);
 
-// The provider bits that require CHROME_ETW_LOGGING in the environment.
-const uint32 kChromeLogProviders =
-    FileLogger::CHROME_LOG_PROVIDER | FileLogger::CHROME_FRAME_LOG_PROVIDER;
-const HKEY kEnvironmentRoot = HKEY_LOCAL_MACHINE;
-const wchar_t kEnvironmentKey[] =
-    L"SYSTEM\\CurrentControlSet\\Control\\Session Manager\\Environment";
-const wchar_t kEnvironment[] = L"Environment";
-const unsigned int kBroadcastTimeoutMilliseconds = 2 * 1000;
-
 }  // namespace
 
-// FileLogger::ScopedSystemEnvironmentVariable implementation.
-
-FileLogger::ScopedSystemEnvironmentVariable::ScopedSystemEnvironmentVariable(
-    const string16& variable,
-    const string16& value) {
-
-  // Set the value in this process and its children.
-  ::SetEnvironmentVariable(variable.c_str(), value.c_str());
-
-  // Set the value for the whole system and ask everyone to refresh.
-  base::win::RegKey environment;
-  LONG result = environment.Open(kEnvironmentRoot, kEnvironmentKey,
-                                 KEY_QUERY_VALUE | KEY_SET_VALUE);
-  if (result == ERROR_SUCCESS) {
-    string16 old_value;
-    // The actual value of the variable is insignificant in the eyes of Chrome.
-    if (environment.ReadValue(variable.c_str(),
-                              &old_value) != ERROR_SUCCESS &&
-        environment.WriteValue(variable.c_str(),
-                               value.c_str()) == ERROR_SUCCESS) {
-      environment.Close();
-      // Remember that this needs to be reversed in the dtor.
-      variable_ = variable;
-      NotifyOtherProcesses();
-    }
-  } else {
-    SetLastError(result);
-    PLOG(ERROR) << "Failed to open HKLM to check/modify the system environment";
-  }
-}
-
-FileLogger::ScopedSystemEnvironmentVariable::~ScopedSystemEnvironmentVariable()
-{
-  if (!variable_.empty()) {
-    base::win::RegKey environment;
-    if (environment.Open(kEnvironmentRoot, kEnvironmentKey,
-                         KEY_SET_VALUE) == ERROR_SUCCESS) {
-      environment.DeleteValue(variable_.c_str());
-      environment.Close();
-      NotifyOtherProcesses();
-    }
-  }
-}
-
-// static
-void FileLogger::ScopedSystemEnvironmentVariable::NotifyOtherProcesses() {
-  // Announce to the system that a change has been made so that the shell and
-  // other Windowsy bits pick it up; see
-  // http://msdn.microsoft.com/en-us/library/windows/desktop/ms682653.aspx.
-  SendMessageTimeout(HWND_BROADCAST, WM_SETTINGCHANGE, 0,
-                     reinterpret_cast<LPARAM>(kEnvironment), SMTO_ABORTIFHUNG,
-                     kBroadcastTimeoutMilliseconds, NULL);
-}
-
 bool FileLogger::is_initialized_ = false;
 
 FileLogger::FileLogger()
     : event_provider_mask_() {
 }
 
 FileLogger::~FileLogger() {
   if (is_logging()) {
     LOG(ERROR)
       << __FUNCTION__ << " don't forget to call FileLogger::StopLogging()";
@@ skipping 54 matching lines @@
     logging::LogEventProvider::Uninitialize();
 }
 
 void FileLogger::Initialize() {
   Initialize(kAllEventProviders);
 }
 
 void FileLogger::Initialize(uint32 event_provider_mask) {
   CHECK(!is_initialized_);
 
-  // Set up CHROME_ETW_LOGGING in the environment if providers that require it
-  // are enabled.
-  if (event_provider_mask & kChromeLogProviders) {
-    etw_logging_configurator_.reset(new ScopedSystemEnvironmentVariable(
-        ASCIIToWide(env_vars::kEtwLogging), L"1"));
-  }
-
   // Stop a previous session that wasn't shut down properly.
   base::win::EtwTraceProperties ignore;
   HRESULT hr = base::win::EtwTraceController::Stop(kChromeTestSession,
                                                    &ignore);
   LOG_IF(ERROR, FAILED(hr) &&
              hr != HRESULT_FROM_WIN32(ERROR_WMI_INSTANCE_NOT_FOUND))
       << "Failed to stop a previous trace session; hr=" << std::hex << hr;
 
   event_provider_mask_ = event_provider_mask;
 
@@ skipping 32 matching lines @@
 
   hr = controller_.Flush(NULL);
   LOG_IF(ERROR, FAILED(hr))
       << "Failed to flush events; hr=" << std::hex << hr;
   hr = controller_.Stop(NULL);
   LOG_IF(ERROR, FAILED(hr))
       << "Failed to stop ETW session; hr=" << std::hex << hr;
 }
 
 }  // namespace logging_win