Issue 9699028: Should make the gpu pixel tests less flaky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9699028: Should make the gpu pixel tests less flaky (Closed)

Created:
8 years, 9 months ago by pkotwicz

Modified:
8 years, 9 months ago

Reviewers:
Zhenyao Mo, Peter Mayo

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Should make the gpu pixel tests less flaky. This patch make the pixel test wait till the browser window is at the desired size before taking a snapshot. Bug=None Test=linux_gpu,win_gpu,mac_gpu try bots TBR=zmo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126682

Patch Set 1 #

Patch Set 2 : Changes as requested #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -30 lines)			Patch
M	chrome/test/data/gpu/pixel_canvas2d.html	View	2 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/test/data/gpu/pixel_css3d.html	View	2 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/test/data/gpu/pixel_webgl.html	View	2 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/test/gpu/gpu_pixel_browsertest.cc	View	3 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/9699028/2001

8 years, 9 months ago (2012-03-14 15:53:53 UTC) #1

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

8 years, 9 months ago (2012-03-14 17:16:10 UTC) #2

Peter Mayo

8 years, 9 months ago (2012-03-14 19:17:39 UTC) #3

Looks to me like this makes the tests that were working on the software pipe
before now time out.

Expand Messages | Collapse Messages