Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: chrome/browser/extensions/extension_prefs.h

Issue 9694038: OBSOLETE REVIEW. See http://codereview.chromium.org/10382149/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_prefs.h
===================================================================
--- chrome/browser/extensions/extension_prefs.h (revision 136836)
+++ chrome/browser/extensions/extension_prefs.h (working copy)
@@ -14,6 +14,7 @@
#include "base/time.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_content_settings_store.h"
+#include "chrome/browser/extensions/extension_management_policy.h"
#include "chrome/browser/extensions/extension_prefs_scope.h"
#include "chrome/browser/extensions/extension_scoped_prefs.h"
#include "chrome/common/extensions/extension.h"
@@ -45,6 +46,7 @@
// PrefValueStore::extension_prefs(), which this class populates and
// maintains as the underlying extensions change.
class ExtensionPrefs : public ExtensionContentSettingsStore::Observer,
+ public ExtensionManagementPolicy::Delegate,
public ExtensionScopedPrefs {
public:
// Key name for a preference that keeps track of per-extension settings. This
@@ -202,10 +204,13 @@
bool IsAppNotificationDisabled(const std::string& extension_id) const;
void SetAppNotificationDisabled(const std::string& extension_id, bool value);
- // Is the extension with |extension_id| allowed by policy (checking both
- // whitelist and blacklist).
- bool IsExtensionAllowedByPolicy(const std::string& extension_id,
- Extension::Location location) const;
+ // ExtensionManagementPolicy::Delegate implementation:
Aaron Boodman 2012/05/17 22:41:06 We usually just say: // ExtensionManagementPolicy
+ // Returns true if the extension with |extension_id| is allowed by policy
Aaron Boodman 2012/05/17 22:41:06 I don't think this comment is necessary since the
Pam (message me for reviews) 2012/05/18 20:15:15 I clarified that this particular management policy
+ // (checking both whitelist and blacklist).
+ virtual bool UserMayInstall(const std::string& extension_id,
+ Extension::Location location,
+ const std::string& extension_name,
+ string16* error) const OVERRIDE;
// Checks if extensions are blacklisted by default, by policy. When true, this
// means that even extensions without an ID should be blacklisted (e.g.

Powered by Google App Engine
This is Rietveld 408576698