OBSOLETE REVIEW. See http://codereview.chromium.org/10382149/

chrome/browser/extensions/extension_management_policy.cc

Index: chrome/browser/extensions/extension_management_policy.cc
===================================================================
--- chrome/browser/extensions/extension_management_policy.cc	(revision 0)
+++ chrome/browser/extensions/extension_management_policy.cc	(revision 0)
@@ -0,0 +1,93 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_management_policy.h"
+
+ExtensionManagementPolicy::ExtensionManagementPolicy() {
+}
+
+ExtensionManagementPolicy::~ExtensionManagementPolicy() {
+}
+
+bool ExtensionManagementPolicy::Delegate::UserMayInstall(
+      const std::string& extension_id,
+      Extension::Location location,
+      const std::string& extension_name,
+      string16* error) const {
+  return true;
+}
+
+// Enable, disable, remove
+bool ExtensionManagementPolicy::Delegate::UserMayModifyStatus(
+    const Extension* extension, string16* error) const {
+  return true;
+}
+// Incognito, file access, etc.
+bool ExtensionManagementPolicy::Delegate::UserMayModifyUsage(
+    const Extension* extension, string16* error) const {
+  return true;
+}
+
+// Forced on
+bool ExtensionManagementPolicy::Delegate::MustRemainEnabled(
+    const Extension* extension, string16* error) const {
+  return false;
+}
+
+void ExtensionManagementPolicy::RegisterDelegate(Delegate* delegate) {
+  delegates_.insert(delegate);
+}
+
+void ExtensionManagementPolicy::UnregisterDelegate(Delegate* delegate) {
+  delegates_.erase(delegate);
+}
+
+bool ExtensionManagementPolicy::UserMayInstall(const std::string& extension_id,
+    Extension::Location location, const std::string& extension_name,
+    string16* error) const {
+  for (DelegateList::const_iterator it = delegates_.begin();
+      it != delegates_.end(); ++it) {
+    if (!(*it)->UserMayInstall(extension_id, location, extension_name, error))

[Aaron Boodman, 2012/05/17 22:41:06]

For debugging purposes, I suggest giving each policy provider a human-readable
name, and then printing out something like:

DLOG(ERROR) << "Installation prevented by " << provider->name();

[Aaron Boodman, 2012/05/17 22:41:06]

It seems like the providers will also be interested in the Extension* itself.
For example, whether it's a theme or an extension, or what permissions it has.
Is it easy where this is called from to pass the whole extension?

[Pam (message me for reviews), 2012/05/18 20:15:15]

Sure. To avoid spam, since these get called to check whether to show UI and so
on too, I'll make it a warning.

[Pam (message me for reviews), 2012/05/18 20:15:15]

Yes, as long as we also pass the location, since CrxInstaller doesn't save that
to the extension until it's successful. Done.

+      return false;
+  }
+  return true;
+}
+
+bool ExtensionManagementPolicy::UserMayModifyStatus(
+    const Extension* extension, string16* error) const {
+  for (DelegateList::const_iterator it = delegates_.begin();
+      it != delegates_.end(); ++it) {
+    if (!(*it)->UserMayModifyStatus(extension, error))
+      return false;
+  }
+  return true;
+}
+
+bool ExtensionManagementPolicy::UserMayModifyUsage(
+    const Extension* extension, string16* error) const {
+  for (DelegateList::const_iterator it = delegates_.begin();
+      it != delegates_.end(); ++it) {
+    if (!(*it)->UserMayModifyUsage(extension, error))
+      return false;
+  }
+  return true;
+}
+
+bool ExtensionManagementPolicy::MustRemainEnabled(
+    const Extension* extension, string16* error) const {
+  for (DelegateList::const_iterator it = delegates_.begin();
+      it != delegates_.end(); ++it) {
+    if ((*it)->MustRemainEnabled(extension, error))
+      return true;
+  }
+  return false;
+}
+
+void ExtensionManagementPolicy::UnregisterAllDelegates() {
+  delegates_.clear();
+}
+
+size_t ExtensionManagementPolicy::CountDelegates() {
+  return delegates_.size();
+}
Property changes on: chrome\browser\extensions\extension_management_policy.cc
___________________________________________________________________
Added: svn:eol-style
   + LF