Add Extension Keybinding test for page actions. This is to facilitate an upcoming port of the PageA…

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 1023 matching lines @@
     for (int i = page_actions.size() - 1; i >= 0; --i) {
       page_action_views_[i] = new PageActionWithBadgeView(
           new PageActionImageView(this, page_actions[i]));
       page_action_views_[i]->SetVisible(false);
       AddChildViewAt(page_action_views_[i], GetIndexOf(view));
     }
   }
 
   WebContents* contents = GetWebContentsFromDelegate(delegate_);
   if (!page_action_views_.empty() && contents) {
-    GURL url = GURL(model_->GetText());
+    GURL url = browser()->GetSelectedWebContents()->GetURL();

[Finnur, 2012/03/15 13:49:29]

A note on this:

GetText() from model_ returns the current URL, but does so in a way that strips
http:// from it. This becomes a problem in the tests since the test URLs loaded
are...
GURL("http://127.0.0.1:20000/foo/bar.html") and stripped that becomes...
GURL("127.0.0.1:20000/foo/bar.html")
... which is not a URL that GURL can parse without assistance (thinks everything
in front of the colon is a scheme).

We could fix it with FixupURL but since we just want the actual URL we might as
well just call GetURL(), which returns the real thing.

I'll fix this in GTK when I port keybindings for page actions to GTK and
activate the test for GTK (I already verified it failed the same way there). I
need to see if Mac has the same problem (once keybindings are ported for Mac).

 
     for (PageActionViews::const_iterator i(page_action_views_.begin());
          i != page_action_views_.end(); ++i) {
       (*i)->UpdateVisibility(model_->input_in_progress() ? NULL : contents,
                              url);
 
       // Check if the visibility of the action changed and notify if it did.
       ExtensionAction* action = (*i)->image_view()->page_action();
       if (old_visibility.find(action) == old_visibility.end() ||
           old_visibility[action] != (*i)->visible()) {
@@ skipping 251 matching lines @@
       !suggested_text_view_->GetText().empty();
 }
 
 #if !defined(USE_AURA)
 OmniboxViewWin* LocationBarView::GetOmniboxViewWin() {
   CHECK(!views::Widget::IsPureViews());
   return static_cast<OmniboxViewWin*>(location_entry_.get());
 }
 #endif
 #endif