Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Element.java

Issue 9692002: Step back and remove more getNode() invocations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/Element.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Element.java b/compiler/java/com/google/dart/compiler/resolver/Element.java
index 62536e01f11d1bad77588a48f283820f4caf2c53..6416f4c82aa317f94fedb17b7f729232e46b812b 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Element.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Element.java
@@ -4,18 +4,17 @@
package com.google.dart.compiler.resolver;
-import com.google.dart.compiler.ast.DartLabel;
import com.google.dart.compiler.ast.DartNode;
import com.google.dart.compiler.ast.Modifiers;
+import com.google.dart.compiler.common.HasSourceInfo;
+import com.google.dart.compiler.common.SourceInfo;
import com.google.dart.compiler.type.Type;
-public interface Element {
+public interface Element extends HasSourceInfo {
String getOriginalName();
DartNode getNode();
- void setNode(DartLabel node);
-
String getName();
ElementKind getKind();
@@ -27,7 +26,12 @@ public interface Element {
Modifiers getModifiers();
/**
- * Returns the innermost {@link EnclosingElement} which declares this element.
+ * @return the innermost {@link Element} which declares this {@link Element}.
+ */
+ Element getEnclosingElement();
zundel 2012/03/12 19:42:31 I don't understand this change. The EnclosingElem
scheglov 2012/03/13 00:42:25 I will undo this in the next CL.
+
+ /**
+ * @return location of the name in the declaration of this {@link Element}.
*/
- EnclosingElement getEnclosingElement();
+ SourceInfo getNameLocation();
zundel 2012/03/12 19:42:31 We will need to be careful about persisting this f
scheglov 2012/03/13 00:42:25 This map is populated lazily. Basically we will se
}

Powered by Google App Engine
This is Rietveld 408576698