Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: compiler/java/com/google/dart/compiler/resolver/Element.java

Issue 9692002: Step back and remove more getNode() invocations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 package com.google.dart.compiler.resolver; 5 package com.google.dart.compiler.resolver;
6 6
7 import com.google.dart.compiler.ast.DartLabel;
8 import com.google.dart.compiler.ast.DartNode; 7 import com.google.dart.compiler.ast.DartNode;
9 import com.google.dart.compiler.ast.Modifiers; 8 import com.google.dart.compiler.ast.Modifiers;
9 import com.google.dart.compiler.common.HasSourceInfo;
10 import com.google.dart.compiler.common.SourceInfo;
10 import com.google.dart.compiler.type.Type; 11 import com.google.dart.compiler.type.Type;
11 12
12 public interface Element { 13 public interface Element extends HasSourceInfo {
13 String getOriginalName(); 14 String getOriginalName();
14 15
15 DartNode getNode(); 16 DartNode getNode();
16 17
17 void setNode(DartLabel node);
18
19 String getName(); 18 String getName();
20 19
21 ElementKind getKind(); 20 ElementKind getKind();
22 21
23 Type getType(); 22 Type getType();
24 23
25 boolean isDynamic(); 24 boolean isDynamic();
26 25
27 Modifiers getModifiers(); 26 Modifiers getModifiers();
28 27
29 /** 28 /**
30 * Returns the innermost {@link EnclosingElement} which declares this element. 29 * @return the innermost {@link Element} which declares this {@link Element}.
31 */ 30 */
32 EnclosingElement getEnclosingElement(); 31 Element getEnclosingElement();
zundel 2012/03/12 19:42:31 I don't understand this change. The EnclosingElem
scheglov 2012/03/13 00:42:25 I will undo this in the next CL.
32
33 /**
34 * @return location of the name in the declaration of this {@link Element}.
35 */
36 SourceInfo getNameLocation();
zundel 2012/03/12 19:42:31 We will need to be careful about persisting this f
scheglov 2012/03/13 00:42:25 This map is populated lazily. Basically we will se
33 } 37 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698