Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tests/corelib/src/StringPatternTest.dart

Issue 9689089: Improve the replaceFirst, replaceAll and split methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address review comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/corelib/corelib.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/src/StringPatternTest.dart
diff --git a/tests/corelib/src/StringPatternTest.dart b/tests/corelib/src/StringPatternTest.dart
index a7e07bf63b05c8b4183f9c82876aad47e366dfc3..3fb35337ed0684e21a7efa1d2c508c902d84a293 100644
--- a/tests/corelib/src/StringPatternTest.dart
+++ b/tests/corelib/src/StringPatternTest.dart
@@ -58,7 +58,7 @@ testTwoMatches() {
testEmptyPattern() {
String pattern = "";
Iterable<Match> matches = pattern.allMatches(str);
- Expect.isFalse(matches.iterator().hasNext());
+ Expect.isTrue(matches.iterator().hasNext());
ngeoffray 2012/03/19 20:13:29 I believe one of these changes broke the leg bot.
ngeoffray 2012/03/19 20:14:15 %s/leg/dart2js
}
testEmptyString() {
@@ -72,5 +72,5 @@ testEmptyPatternAndString() {
String pattern = "";
String str = "";
Iterable<Match> matches = pattern.allMatches(str);
- Expect.isFalse(matches.iterator().hasNext());
+ Expect.isTrue(matches.iterator().hasNext());
}
« no previous file with comments | « tests/corelib/corelib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698