Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: tests/corelib/src/StringPatternTest.dart

Issue 9689089: Improve the replaceFirst, replaceAll and split methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address review comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/corelib/corelib.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Dart test for testing String.allMatches. 4 // Dart test for testing String.allMatches.
5 5
6 String str = "this is a string with hello here and hello there"; 6 String str = "this is a string with hello here and hello there";
7 7
8 main() { 8 main() {
9 testNoMatch(); 9 testNoMatch();
10 testOneMatch(); 10 testOneMatch();
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 Expect.equals(helloPattern, match[0]); 51 Expect.equals(helloPattern, match[0]);
52 Expect.equals(0, match.groupCount()); 52 Expect.equals(0, match.groupCount());
53 start = match.end(); 53 start = match.end();
54 } 54 }
55 Expect.equals(2, count); 55 Expect.equals(2, count);
56 } 56 }
57 57
58 testEmptyPattern() { 58 testEmptyPattern() {
59 String pattern = ""; 59 String pattern = "";
60 Iterable<Match> matches = pattern.allMatches(str); 60 Iterable<Match> matches = pattern.allMatches(str);
61 Expect.isFalse(matches.iterator().hasNext()); 61 Expect.isTrue(matches.iterator().hasNext());
ngeoffray 2012/03/19 20:13:29 I believe one of these changes broke the leg bot.
ngeoffray 2012/03/19 20:14:15 %s/leg/dart2js
62 } 62 }
63 63
64 testEmptyString() { 64 testEmptyString() {
65 String pattern = "foo"; 65 String pattern = "foo";
66 String str = ""; 66 String str = "";
67 Iterable<Match> matches = pattern.allMatches(str); 67 Iterable<Match> matches = pattern.allMatches(str);
68 Expect.isFalse(matches.iterator().hasNext()); 68 Expect.isFalse(matches.iterator().hasNext());
69 } 69 }
70 70
71 testEmptyPatternAndString() { 71 testEmptyPatternAndString() {
72 String pattern = ""; 72 String pattern = "";
73 String str = ""; 73 String str = "";
74 Iterable<Match> matches = pattern.allMatches(str); 74 Iterable<Match> matches = pattern.allMatches(str);
75 Expect.isFalse(matches.iterator().hasNext()); 75 Expect.isTrue(matches.iterator().hasNext());
76 } 76 }
OLDNEW
« no previous file with comments | « tests/corelib/corelib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698