Clean up ShortcutsProvider and related classes.

Clean up ShortcutsProvider and related classes:

* Move SpansToString()/SpansFromString() and AddLastMatchIfNeeded() from static functions in shortcuts_provider_shortcut.cc to static members on AutocompleteMatch and rename them, to go along with the other existing classification-related functions there, since there's nothing particularly shortcut-related about them.
* Move the definitions of Shortcut and ShortcutMap to the ShortcutsBackend, mainly to "namespace" them -- having a global-scope type named "Shortcut" didn't seem like a good idea.  This made sense as a location anyway since the backend already depended heavily on these types.
* Eliminate using statements.
* Modify ShortcutsProviderTest::FillData() so it can be reused in an additional place.
* Shortcut had two different constructors whose function and use was confusing and error-prone -- they took some of the same fields but as different types, and didn't guarantee all the members were initialized.  Condense to one constructor which takes the most logical types and sets all members.
* Eliminate ShortcutsBackend::guid_map() (unused).
* Simplify/clarify code.
* Eliminate 2K clamp on shortcut data fields.  We don't clamp like this elsewhere, and if the clamp kicks in, it could lead to corrupted results -- e.g. trimming a "description" field but not updating the classifications for that field.

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126743

[Peter Kasting, 2012-03-13 22:27:18]

georgey: To review
brettw: OWNERS stamp for history/

[brettw, 2012-03-13 22:47:23]

History owners LGTM, I didn't really review the details.

https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/history/...
File chrome/browser/history/shortcuts_backend.h (right):

https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/history/...
chrome/browser/history/shortcuts_backend.h:54: GURL url;       // The
corresponding destination URL.
Either use 2-spaces or align them all the same.

[GeorgeY, 2012-03-14 19:59:49]

LGTM with a nit

https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/autocomp...
File chrome/browser/autocomplete/shortcuts_provider.cc (right):

https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/autocomp...
chrome/browser/autocomplete/shortcuts_provider.cc:225: match_start,
ACMatchClassification::MATCH);
May be move &match_class, to the same line as the rest of the parameters? Right
now it looks like two different styles are used.

https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/autocomp...
chrome/browser/autocomplete/shortcuts_provider.cc:228: match_end,
ACMatchClassification::NONE);
Here is well

https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/autocomp...
chrome/browser/autocomplete/shortcuts_provider.cc:242: std::max(i->offset,
j->offset), i->style | j->style);
and here

[Peter Kasting, 2012-03-14 20:37:34]

https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/autocomp...
File chrome/browser/autocomplete/shortcuts_provider.cc (right):

https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/autocomp...
chrome/browser/autocomplete/shortcuts_provider.cc:225: match_start,
ACMatchClassification::MATCH);
On 2012/03/14 19:59:49, GeorgeY wrote:
> May be move &match_class, to the same line as the rest of the parameters?
Right
> now it looks like two different styles are used.

This is explicitly OK: search for the "AndAnotherLongFunctionCall" example in
http://dev.chromium.org/developers/coding-style .

[GeorgeY, 2012-03-14 20:50:23]

On 2012/03/14 20:37:34, Peter Kasting wrote:
>
https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/autocomp...
> File chrome/browser/autocomplete/shortcuts_provider.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9689085/diff/1/chrome/browser/autocomp...
> chrome/browser/autocomplete/shortcuts_provider.cc:225: match_start,
> ACMatchClassification::MATCH);
> On 2012/03/14 19:59:49, GeorgeY wrote:
> > May be move &match_class, to the same line as the rest of the parameters?
> Right
> > now it looks like two different styles are used.
> 
> This is explicitly OK: search for the "AndAnotherLongFunctionCall" example in
> http://dev.chromium.org/developers/coding-style .
OK, I see. LGTM, then