Clean up ShortcutsProvider and related classes.

chrome/browser/autocomplete/shortcuts_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/shortcuts_provider.h"
 
 #include <math.h>
 
 #include <algorithm>
 #include <functional>
@@ skipping 10 matching lines @@
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/in_memory_url_index.h"
 #include "chrome/browser/history/shortcuts_backend.h"
 #include "chrome/browser/history/url_database.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-using base::Time;
-using base::TimeDelta;
-
 using content::BrowserThread;
 
 namespace {
 
 struct TestShortcutInfo {
   std::string guid;
   std::string url;
   std::string title;  // The text that orginally was searched for.
   std::string contents;
   std::string contents_class;
@@ skipping 94 matching lines @@
     std::set<std::string> Leftovers() const { return matches_; }
 
    private:
     std::set<std::string> matches_;
   };
 
   void SetUp();
   void TearDown();
 
   // Fills test data into the provider.
-  void FillData();
+  void FillData(TestShortcutInfo* db, size_t db_size);
 
   // Runs an autocomplete query on |text| and checks to see that the returned
   // results' destination URLs match those provided. |expected_urls| does not
   // need to be in sorted order.
   void RunTest(const string16 text,
                std::vector<std::string> expected_urls,
                std::string expected_top_result);
 
   MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
@@ skipping 15 matching lines @@
 void ShortcutsProviderTest::OnProviderUpdate(bool updated_matches) {
 }
 
 void ShortcutsProviderTest::SetUp() {
   profile_.reset(new TestingProfile());
   profile_->CreateHistoryService(true, false);
   provider_ = new ShortcutsProvider(this, profile_.get());
   mock_backend_ = new history::ShortcutsBackend(FilePath(), profile_.get());
   mock_backend_->Init();
   provider_->set_shortcuts_backend(mock_backend_.get());
-  FillData();
+  FillData(shortcut_test_db, arraysize(shortcut_test_db));
 }
 
 void ShortcutsProviderTest::TearDown() {
   provider_ = NULL;
 }
 
-void ShortcutsProviderTest::FillData() {
+void ShortcutsProviderTest::FillData(TestShortcutInfo* db, size_t db_size) {
   DCHECK(provider_.get());
-  mock_backend_->DeleteAllShortcuts();
-  for (size_t i = 0; i < arraysize(shortcut_test_db); ++i) {
-    const TestShortcutInfo& cur = shortcut_test_db[i];
-    const GURL current_url(cur.url);
-    Time visit_time = Time::Now() - TimeDelta::FromDays(cur.days_from_now);
-    shortcuts_provider::Shortcut shortcut(
-        ASCIIToUTF16(cur.title),
-        current_url,
-        ASCIIToUTF16(cur.contents),
-        shortcuts_provider::SpansFromString(ASCIIToUTF16(cur.contents_class)),
+  for (size_t i = 0; i < db_size; ++i) {
+    const TestShortcutInfo& cur = db[i];
+    history::ShortcutsBackend::Shortcut shortcut(cur.guid,
+        ASCIIToUTF16(cur.title), GURL(cur.url), ASCIIToUTF16(cur.contents),
+        AutocompleteMatch::ClassificationsFromString(cur.contents_class),
         ASCIIToUTF16(cur.description),
-        shortcuts_provider::SpansFromString(
-            ASCIIToUTF16(cur.description_class)));
-    shortcut.last_access_time = visit_time;
-    shortcut.number_of_hits = cur.typed_count;
-    shortcut.id = cur.guid;
+        AutocompleteMatch::ClassificationsFromString(cur.description_class),
+        base::Time::Now() - base::TimeDelta::FromDays(cur.days_from_now),
+        cur.typed_count);
     mock_backend_->AddShortcut(shortcut);
   }
 }
 
 ShortcutsProviderTest::SetShouldContain::SetShouldContain(
     const ACMatches& matched_urls) {
   for (ACMatches::const_iterator iter = matched_urls.begin();
        iter != matched_urls.end(); ++iter)
     matches_.insert(iter->destination_url.spec());
 }
@@ skipping 339 matching lines @@
   ACMatchClassifications spans_content;
   spans_content.push_back(ACMatchClassification(0, ACMatchClassification::URL));
   spans_content.push_back(ACMatchClassification(
       4, ACMatchClassification::MATCH | ACMatchClassification::URL));
   spans_content.push_back(ACMatchClassification(8, ACMatchClassification::URL));
   ACMatchClassifications spans_description;
   spans_description.push_back(
       ACMatchClassification(0, ACMatchClassification::NONE));
   spans_description.push_back(
       ACMatchClassification(2, ACMatchClassification::MATCH));
-  shortcuts_provider::Shortcut shortcut(ASCIIToUTF16("test"),
-                                        GURL("http://www.test.com"),
-                                        ASCIIToUTF16("www.test.com"),
-                                        spans_content,
-                                        ASCIIToUTF16("A test"),
-                                        spans_description);
+  history::ShortcutsBackend::Shortcut shortcut(std::string(),
+      ASCIIToUTF16("test"), GURL("http://www.test.com"),
+      ASCIIToUTF16("www.test.com"), spans_content, ASCIIToUTF16("A test"),
+      spans_description, base::Time::Now(), 1);
 
   // Maximal score.
-  shortcut.last_access_time = Time::Now();
   const int kMaxScore = ShortcutsProvider::CalculateScore(
       ASCIIToUTF16("test"), shortcut);
 
   // Score decreases as percent of the match is decreased.
   int score_three_quarters =
       ShortcutsProvider::CalculateScore(ASCIIToUTF16("tes"), shortcut);
   EXPECT_LT(score_three_quarters, kMaxScore);
   int score_one_half =
       ShortcutsProvider::CalculateScore(ASCIIToUTF16("te"), shortcut);
   EXPECT_LT(score_one_half, score_three_quarters);
   int score_one_quarter =
       ShortcutsProvider::CalculateScore(ASCIIToUTF16("t"), shortcut);
   EXPECT_LT(score_one_quarter, score_one_half);
 
   // Should decay with time - one week.
-  shortcut.last_access_time = Time::Now() - TimeDelta::FromDays(7);
+  shortcut.last_access_time = base::Time::Now() - base::TimeDelta::FromDays(7);
   int score_week_old =
       ShortcutsProvider::CalculateScore(ASCIIToUTF16("test"), shortcut);
   EXPECT_LT(score_week_old, kMaxScore);
 
   // Should decay more in two weeks.
-  shortcut.last_access_time = Time::Now() - TimeDelta::FromDays(14);
+  shortcut.last_access_time = base::Time::Now() - base::TimeDelta::FromDays(14);
   int score_two_weeks_old =
       ShortcutsProvider::CalculateScore(ASCIIToUTF16("test"), shortcut);
   EXPECT_LT(score_two_weeks_old, score_week_old);
 
   // But not if it was activly clicked on. 2 hits slow decaying power.
   shortcut.number_of_hits = 2;
-  shortcut.last_access_time = Time::Now() - TimeDelta::FromDays(14);
+  shortcut.last_access_time = base::Time::Now() - base::TimeDelta::FromDays(14);
   int score_popular_two_weeks_old =
       ShortcutsProvider::CalculateScore(ASCIIToUTF16("test"), shortcut);
   EXPECT_LT(score_two_weeks_old, score_popular_two_weeks_old);
   // But still decayed.
   EXPECT_LT(score_popular_two_weeks_old, kMaxScore);
 
   // 3 hits slow decaying power even more.
   shortcut.number_of_hits = 3;
-  shortcut.last_access_time = Time::Now() - TimeDelta::FromDays(14);
+  shortcut.last_access_time = base::Time::Now() - base::TimeDelta::FromDays(14);
   int score_more_popular_two_weeks_old =
       ShortcutsProvider::CalculateScore(ASCIIToUTF16("test"), shortcut);
   EXPECT_LT(score_two_weeks_old, score_more_popular_two_weeks_old);
   EXPECT_LT(score_popular_two_weeks_old, score_more_popular_two_weeks_old);
   // But still decayed.
   EXPECT_LT(score_more_popular_two_weeks_old, kMaxScore);
 }
 
 TEST_F(ShortcutsProviderTest, DeleteMatch) {
   TestShortcutInfo shortcuts_to_test_delete[3] = {
     { "BD85DBA2-8C29-49F9-84AE-48E1E90880F1",
       "http://www.deletetest.com/1.html", "delete",
       "http://www.deletetest.com/1.html", "0,2",
       "Erase this shortcut!", "0,0", 1, 1},
     { "BD85DBA2-8C29-49F9-84AE-48E1E90880F2",
       "http://www.deletetest.com/1.html", "erase",
       "http://www.deletetest.com/1.html", "0,2",
       "Erase this shortcut!", "0,0", 1, 1},
     { "BD85DBA2-8C29-49F9-84AE-48E1E90880F3",
       "http://www.deletetest.com/2.html", "delete",
       "http://www.deletetest.com/2.html", "0,2",
       "Erase this shortcut!", "0,0", 1, 1},
   };
 
   size_t original_shortcuts_count =
       provider_->shortcuts_backend_->shortcuts_map().size();
 
-  for (size_t i = 0; i < arraysize(shortcuts_to_test_delete); ++i) {
-    const TestShortcutInfo& cur = shortcuts_to_test_delete[i];
-    const GURL current_url(cur.url);
-    Time visit_time = Time::Now() - TimeDelta::FromDays(cur.days_from_now);
-    shortcuts_provider::Shortcut shortcut(
-        ASCIIToUTF16(cur.title),
-        current_url,
-        ASCIIToUTF16(cur.contents),
-        shortcuts_provider::SpansFromString(ASCIIToUTF16(cur.contents_class)),
-        ASCIIToUTF16(cur.description),
-        shortcuts_provider::SpansFromString(
-            ASCIIToUTF16(cur.description_class)));
-    shortcut.last_access_time = visit_time;
-    shortcut.id = cur.guid;
-    mock_backend_->AddShortcut(shortcut);
-  }
+  FillData(shortcuts_to_test_delete, arraysize(shortcuts_to_test_delete));
 
   EXPECT_EQ(original_shortcuts_count + 3,
             provider_->shortcuts_backend_->shortcuts_map().size());
   EXPECT_FALSE(provider_->shortcuts_backend_->shortcuts_map().end() ==
                provider_->shortcuts_backend_->shortcuts_map().find(
                    ASCIIToUTF16("delete")));
   EXPECT_FALSE(provider_->shortcuts_backend_->shortcuts_map().end() ==
                provider_->shortcuts_backend_->shortcuts_map().find(
                    ASCIIToUTF16("erase")));
 
@@ skipping 21 matching lines @@
   match.contents = ASCIIToUTF16(shortcuts_to_test_delete[2].contents);
   match.description = ASCIIToUTF16(shortcuts_to_test_delete[2].description);
 
   provider_->DeleteMatch(match);
   EXPECT_EQ(original_shortcuts_count,
             provider_->shortcuts_backend_->shortcuts_map().size());
   EXPECT_TRUE(provider_->shortcuts_backend_->shortcuts_map().end() ==
               provider_->shortcuts_backend_->shortcuts_map().find(
                   ASCIIToUTF16("delete")));
 }