Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 9689069: MIPS: Remove static initializers in v8. (Closed)

Created:
8 years, 9 months ago by kalmard
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Remove static initializers in v8. Port r11010 (1daa81bc). MIPS-specific changes: -register codes and registers are defined using a macro to avoid redundancy -renamed s8_fp to fp, removed the "fp" alias -removed kSavedValueRegister (found by check-static-initializers.sh) Original commit message: Landing for pliard@chromium.org: Remove static initializers in v8. This change includes two CLs by pliard@chromium.org: 1. http://codereview.chromium.org/9447052/ (Add CallOnce() and simple LazyInstance implementation): Note that this implementation of LazyInstance does not handle global destructors (i.e. the lazy instances a This CL was initially reviewed on codereview.appspot.com: http://codereview.appspot.com/5687064/ 2. http://codereview.chromium.org/9455088/ (Remove static initializers in v8): This CL depends on CL 9447052 (adding CallOnce and LazyInstance). It is based on a patch sent by Digit. With this patch applied, we have only one static initializer left (in atomicops_internals_x86_gcc.cc). This This CL also modifies the presubmit script to check the number of static initializers. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11241

Patch Set 1 #

Patch Set 2 : rebased on r11201 #

Patch Set 3 : rebased on r11230 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -95 lines) Patch
M src/mips/assembler-mips.h View 1 2 chunks +53 lines, -35 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 3 chunks +12 lines, -12 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 8 chunks +34 lines, -31 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.cc View 6 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kalmard
8 years, 9 months ago (2012-03-13 18:10:17 UTC) #1
fschneider
lgtm
8 years, 9 months ago (2012-03-20 10:59:48 UTC) #2
fschneider
On 2012/03/20 10:59:48, fschneider wrote: > lgtm We reverted the corresponding change on the trunk ...
8 years, 9 months ago (2012-03-27 11:19:41 UTC) #3
kalmard
rebased on r11201
8 years, 8 months ago (2012-03-31 11:22:49 UTC) #4
kalmard
8 years, 8 months ago (2012-04-05 08:40:25 UTC) #5
rebased on r11230

Powered by Google App Engine
This is Rietveld 408576698