Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9677008: Not properly handling backslashes for extra files on Windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 5355)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -528,6 +528,9 @@
List<String> otherScripts = optionsFromFile['otherScripts'];
for (String name in otherScripts) {
int end = filename.lastIndexOf('/');
+ if (new Platform().operatingSystem() == 'windows' && end == -1) {
Siggi Cherem (dart-lang) 2012/03/12 20:44:08 seems odd though - the filenames come from a strin
+ end = filename.lastIndexOf('\\');
+ }
if (end == -1) {
print('Warning: error processing "OtherScripts" of $filename.');
print('Skipping test ($testName).');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698