Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9677008: Not properly handling backslashes for extra files on Windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 List<Command> commands = []; 521 List<Command> commands = [];
522 if (component != 'dartium') { 522 if (component != 'dartium') {
523 commands.add(_compileCommand( 523 commands.add(_compileCommand(
524 dartWrapperFilename, compiledDartWrapperFilename, 524 dartWrapperFilename, compiledDartWrapperFilename,
525 component, tempDir.path, vmOptions)); 525 component, tempDir.path, vmOptions));
526 526
527 // some tests require compiling multiple input scripts. 527 // some tests require compiling multiple input scripts.
528 List<String> otherScripts = optionsFromFile['otherScripts']; 528 List<String> otherScripts = optionsFromFile['otherScripts'];
529 for (String name in otherScripts) { 529 for (String name in otherScripts) {
530 int end = filename.lastIndexOf('/'); 530 int end = filename.lastIndexOf('/');
531 if (new Platform().operatingSystem() == 'windows' && end == -1) {
Siggi Cherem (dart-lang) 2012/03/12 20:44:08 seems odd though - the filenames come from a strin
532 end = filename.lastIndexOf('\\');
533 }
531 if (end == -1) { 534 if (end == -1) {
532 print('Warning: error processing "OtherScripts" of $filename.'); 535 print('Warning: error processing "OtherScripts" of $filename.');
533 print('Skipping test ($testName).'); 536 print('Skipping test ($testName).');
534 return; 537 return;
535 } 538 }
536 String dir = filename.substring(0, end); 539 String dir = filename.substring(0, end);
537 end = name.lastIndexOf('.dart'); 540 end = name.lastIndexOf('.dart');
538 if (end == -1) { 541 if (end == -1) {
539 print('Warning: error processing "OtherScripts" in $filename.'); 542 print('Warning: error processing "OtherScripts" in $filename.');
540 print('Skipping test ($testName).'); 543 print('Skipping test ($testName).');
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 * $noCrash tests are expected to be flaky but not crash 1237 * $noCrash tests are expected to be flaky but not crash
1235 * $pass tests are expected to pass 1238 * $pass tests are expected to pass
1236 * $failOk tests are expected to fail that we won't fix 1239 * $failOk tests are expected to fail that we won't fix
1237 * $fail tests are expected to fail that we should fix 1240 * $fail tests are expected to fail that we should fix
1238 * $crash tests are expected to crash that we should fix 1241 * $crash tests are expected to crash that we should fix
1239 * $timeout tests are allowed to timeout 1242 * $timeout tests are allowed to timeout
1240 """; 1243 """;
1241 print(report); 1244 print(report);
1242 } 1245 }
1243 } 1246 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698