Notify RenderWidgets when "tab fullscreen" state changes.

Notify RenderWidgets when "tab fullscreen" state changes.
BUG=116044
TEST=manual
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126513

[bbudge, 2012-03-09 22:05:42]

I'd like to add a test. Can you suggest what kind of test would be appropriate?

[darin (slow to review), 2012-03-09 22:34:30]

LGTM

[darin (slow to review), 2012-03-09 22:34:56]

On 2012/03/09 22:05:42, bbudge1 wrote:
> I'd like to add a test. Can you suggest what kind of test would be
appropriate?

This could perhaps be tested using a browser test.  I'm not sure if we have any
browser tests for fullscreen mode though.

[bbudge, 2012-03-12 20:29:58]

Adding ben for chrome/browser/ui/browser.cc

A change I want to make in RenderWidgetHostImpl is calling
FullscreenController::IsFullscreenForTab slightly more often during resize
operations. This is causing a DCHECK to be hit during Linux try runs. The
simplest fix is to change the implementation in browser.cc to call
IsFullscreenForTabOrPending. Is there a problem with this approach?

[Ben Goodger (Google), 2012-03-12 20:41:52]

lgtm

[commit-bot: I haz the power, 2012-03-12 22:28:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/9673001/15001

[commit-bot: I haz the power, 2012-03-13 01:09:19]

Try job failure for 9673001-15001 (retry) on win_rel for steps
"installer_util_unittests, check_deps".
It's a second try, previously, steps "installer_util_unittests, check_deps"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-13 20:47:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/9673001/15001