DescriptionAttempting to re-land the feature.
Revert 127730 - Revert 127717 - Revert 118788 - Revert 113405 - Revert 113305 - Revert 113300 - Revert 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob
ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
Added NET_EXPORT for layered_pool class defintion to fix windows shared compile.
BUG=62364, 92244, 109876, 110368
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127717
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127893
Patch Set 1 #Patch Set 2 : Reland willchan's patch with eroman's fixes. #
Total comments: 10
Patch Set 3 : Fix mmenke's comments #Patch Set 4 : Rebase #
Total comments: 16
Patch Set 5 : Add effective test of SpdySession::CloseOneIdleConnection #Patch Set 6 : Change DCHECK to CHECK. #Patch Set 7 : Fix copyright. #Patch Set 8 : Add test that exercises the codepath which caused http://crbug.com/109876 #Patch Set 9 : Add test that exercises the codepath which caused http://crbug.com/109876 #Patch Set 10 : Rename test to CloseIdleSpdySessionToOpenNewOne #
Total comments: 18
Patch Set 11 : Switch from CHECK to if, since other things can hold ref to SpdySession. #Patch Set 12 : Address mmenke's comments #
Total comments: 2
Patch Set 13 : Fix nit #Patch Set 14 : Fix nit #Patch Set 15 : Rebase #Messages
Total messages: 24 (0 generated)
|