Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 9666032: Cleanup deprecated PyAuto media tests. (Closed)

Created:
8 years, 9 months ago by DaleCurtis
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Nirnimesh, John Grabowski, feature-media-reviews_chromium.org, anantha, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Cleanup deprecated PyAuto tests. Now that all the new tests have landed, the old versions can be removed. Also removes data files which are Chrome OS only, we can add it back to ChromeOS specific tests when we have those. BUG=110779, 106263 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126712

Patch Set 1 #

Patch Set 2 : Revert used files. #

Patch Set 3 : Rebase. #

Patch Set 4 : Update year. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2272 lines) Patch
D chrome/test/data/media/csv/media_list_data.csv View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/media/csv/media_matrix_data.csv View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/media/csv/media_matrix_data_public.csv View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/media/csv/testscenario.csv View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/media/html/media_event.html View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/test/data/media/html/media_fps.html View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/test/data/media/html/media_perf.html View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/test/data/media/html/media_track.html View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/test/data/media/html/player.js View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/test/functional/media/media_fps.py View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/test/functional/media/media_perf.py View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/test/functional/media/media_playbacktime.py View 1 chunk +0 lines, -61 lines 0 comments Download
A chrome/test/functional/media/media_stat_perf.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/functional/media/media_test_base.py View 1 chunk +0 lines, -227 lines 0 comments Download
D chrome/test/functional/media/media_test_env_names.py View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/test/functional/media/media_test_matrix.py View 1 chunk +0 lines, -220 lines 0 comments Download
D chrome/test/functional/media/media_test_matrix_unittest.py View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/test/functional/media/media_test_runner.py View 1 chunk +0 lines, -305 lines 0 comments Download
D chrome/test/functional/media/media_track.py View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/test/functional/media/pyauto_media.py View 1 2 3 3 chunks +1 line, -16 lines 0 comments Download
D chrome/test/functional/media/ui_perf_test_measure_thread.py View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/test/functional/media/ui_perf_test_utils.py View 1 chunk +0 lines, -336 lines 0 comments Download
D chrome/test/functional/media/ui_perf_test_utils_unittest.py View 1 chunk +0 lines, -157 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
DaleCurtis
Cleanup bonanza!
8 years, 9 months ago (2012-03-10 02:54:59 UTC) #1
imasaki1
Did you make sure those files are not used? For example, the following files might ...
8 years, 9 months ago (2012-03-10 03:53:24 UTC) #2
Ami GONE FROM CHROMIUM
What's with chrome/test/functional/media/media_fps_perf.py ? I don't know anything about any of this, so I'm deferring ...
8 years, 9 months ago (2012-03-10 18:02:55 UTC) #3
shadi
Ami, media_fps_perf.py is supposed to replace media_fps.py. However, media_fps_perf.py got combined with cpu/memory perf test ...
8 years, 9 months ago (2012-03-12 17:53:06 UTC) #4
Ami GONE FROM CHROMIUM
> > media_fps_perf.py is supposed to replace media_fps.py. However, > media_fps_perf.py got combined with cpu/memory ...
8 years, 9 months ago (2012-03-12 17:55:57 UTC) #5
DaleCurtis
Thanks for the pointer Kenji, all of the root files in data/media are used by ...
8 years, 9 months ago (2012-03-12 18:11:42 UTC) #6
imasaki1
lgtm
8 years, 9 months ago (2012-03-13 20:30:11 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-13 20:33:00 UTC) #8
DaleCurtis
+dbj can you lgtm this?
8 years, 9 months ago (2012-03-13 20:37:12 UTC) #9
dennis_jeffrey
LGTM
8 years, 9 months ago (2012-03-13 22:30:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/9666032/5001
8 years, 9 months ago (2012-03-13 22:48:41 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 22:52:46 UTC) #12
Try job failure for 9666032-5001 on mac_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698