Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9665008: views: Nuke is_mouse_gesture parameter from ContextMenuController::ShowContextMenuForView(). (Closed)

Created:
8 years, 9 months ago by tfarina
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, penghuang+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

views: Nuke is_mouse_gesture parameter from ContextMenuController::ShowContextMenuForView(). BUG=117092 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126081

Patch Set 1 #

Total comments: 2

Patch Set 2 : nuke is_mouse_gesture parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -85 lines) Patch
M ash/app_list/app_list_item_view.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/app_list/app_list_item_view.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ash/launcher/launcher_view.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/launcher/launcher_view.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ash/shell/window_type_launcher.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/frame/browser_view.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/frame/browser_view.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 4 chunks +10 lines, -12 lines 0 comments Download
M ui/views/context_menu_controller.h View 1 2 chunks +4 lines, -9 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 3 chunks +4 lines, -6 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M ui/views/examples/tree_view_example.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/examples/tree_view_example.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
http://codereview.chromium.org/9665008/diff/1/ui/views/context_menu_controller.h File ui/views/context_menu_controller.h (right): http://codereview.chromium.org/9665008/diff/1/ui/views/context_menu_controller.h#newcode44 ui/views/context_menu_controller.h:44: GestureType gesture_type) = 0; Looks like this parameter isn't ...
8 years, 9 months ago (2012-03-09 19:23:28 UTC) #1
sky
http://codereview.chromium.org/9665008/diff/1/ui/views/context_menu_controller.h File ui/views/context_menu_controller.h (right): http://codereview.chromium.org/9665008/diff/1/ui/views/context_menu_controller.h#newcode44 ui/views/context_menu_controller.h:44: GestureType gesture_type) = 0; On 2012/03/09 19:23:29, tfarina wrote: ...
8 years, 9 months ago (2012-03-09 20:18:17 UTC) #2
tfarina
On 2012/03/09 20:18:17, sky wrote: > http://codereview.chromium.org/9665008/diff/1/ui/views/context_menu_controller.h > File ui/views/context_menu_controller.h (right): > > http://codereview.chromium.org/9665008/diff/1/ui/views/context_menu_controller.h#newcode44 > ...
8 years, 9 months ago (2012-03-10 18:39:42 UTC) #3
sky
8 years, 9 months ago (2012-03-11 22:05:36 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698