chrome/browser/password_manager/password_store_default.cc - Issue 9665007: Profile refactoring: Remove all PasswordStore code from the Profile interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_default.cc

Issue 9665007: Profile refactoring: Remove all PasswordStore code from the Profile interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win and Mac Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_default.h ('K') | « chrome/browser/password_manager/password_store_default.h ('k') | chrome/browser/password_manager/password_store_default_unittest.cc » ('j') | chrome/browser/password_manager/password_store_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_default.cc

diff --git a/chrome/browser/password_manager/password_store_default.cc b/chrome/browser/password_manager/password_store_default.cc

index a0544b6f64cc4d5384c7ad2a0e985a75a7457b1c..bf200a248b8e51258adba9a27218bfaf7cd749ed 100644

--- a/chrome/browser/password_manager/password_store_default.cc

+++ b/chrome/browser/password_manager/password_store_default.cc

@@ -118,8 +118,9 @@ PasswordStoreDefault::~PasswordStoreDefault() {

DCHECK(!migrate_helper_.get());

}

-void PasswordStoreDefault::Shutdown() {

+void PasswordStoreDefault::ShutdownOnUIThread() {

migrate_helper_.reset();

Mike Mammarella 2012/03/10 05:11:52 Should there be a DCHECK(BrowserThread::CurrentlyO

Elliot Glaysher 2012/03/12 19:59:40 I've added this, but just temporarily forever. Wh

+ profile_ = NULL;

}

void PasswordStoreDefault::ReportMetricsImpl() {