Profile refactoring: Remove all PasswordStore code from the Profile interface.

chrome/browser/password_manager/password_store_default.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_store_default.h"
 
 #include <set>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 100 matching lines @@
   DCHECK(web_data_service);
   MigrateIfNecessary();
 }
 
 PasswordStoreDefault::~PasswordStoreDefault() {
   // MigrateHelper should always be NULL as Shutdown should be invoked before
   // the destructor.
   DCHECK(!migrate_helper_.get());
 }
 
-void PasswordStoreDefault::Shutdown() {
+void PasswordStoreDefault::ShutdownOnUIThread() {
   migrate_helper_.reset();

[Mike Mammarella, 2012/03/10 05:11:52]

Should there be a DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); here?

[Elliot Glaysher, 2012/03/12 19:59:40]

I've added this, but just temporarily forever.

What I want is for there to be a DCHECK in the caller (and eventually there will
be), but because so many of our unit tests don't set up mock threads, it is
infeasable. :(

+  profile_ = NULL;
 }
 
 void PasswordStoreDefault::ReportMetricsImpl() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
   login_db_->ReportMetrics();
 }
 
 void PasswordStoreDefault::AddLoginImpl(const PasswordForm& form) {
   if (login_db_->AddLogin(form)) {
     PasswordStoreChangeList changes;
@@ skipping 78 matching lines @@
 }
 
 void PasswordStoreDefault::MigrateIfNecessary() {
   PrefService* prefs = profile_->GetPrefs();
   if (prefs->FindPreference(prefs::kLoginDatabaseMigrated))
     return;
   DCHECK(!migrate_helper_.get());
   migrate_helper_.reset(new MigrateHelper(profile_, web_data_service_, this));
   migrate_helper_->Init();
 }