Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 9664070: Don't take UnkownOSRValues into account when infering Phi's representation. (Closed)

Created:
8 years, 9 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Don't take UnkownOSRValues into account when infering Phi's representation. For DIV with uninitialized result assume double result representation. R=fschneider@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11041

Patch Set 1 #

Patch Set 2 : adjust type feedback for DIV #

Patch Set 3 : improve representation inference for phis with constants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M src/hydrogen.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 1 chunk +1 line, -14 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/type-info.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 9 months ago (2012-03-12 16:05:55 UTC) #1
fschneider
lgtm
8 years, 9 months ago (2012-03-12 16:09:31 UTC) #2
Vyacheslav Egorov (Chromium)
extended patch with type feedback correction for DIV, please take a look
8 years, 9 months ago (2012-03-12 16:40:18 UTC) #3
fschneider
still LGTM.
8 years, 9 months ago (2012-03-13 08:52:28 UTC) #4
fschneider
8 years, 9 months ago (2012-03-14 12:28:24 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698